Page MenuHomeDevCentral
Differential D639

New library to fetch a Mailgun stored message
ClosedPublic
Actions

Authored by dereckson on Sep 1 2016, 16:51.
Tags
None
Referenced Files
F3774622: D639.id1599.diff
Sun, Nov 24, 13:00
Unknown Object (File)
Fri, Nov 22, 10:39
Unknown Object (File)
Fri, Nov 22, 09:48
Unknown Object (File)
Fri, Nov 22, 09:44
Unknown Object (File)
Fri, Nov 22, 09:31
Unknown Object (File)
Fri, Nov 22, 09:18
Unknown Object (File)
Fri, Nov 22, 09:04
Unknown Object (File)
Fri, Nov 22, 08:59
View All Files
Subscribers
None

Details

Reviewers
Sandlayth
Maniphest Tasks
T1000: Detect builds issues with Docker images
Commits
rKMAILGUNcbdfbd39de48: New library to fetch a Mailgun stored message
Summary

Ref T1000

Test Plan

Unit tests

Diff Detail

Repository
rKMAILGUN Keruald Mailgun
Lint
Lint Passed
Unit
Tests Passed
Branch
master
Build Status
Buildable 966
Build 1156: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1598.Sep 1 2016, 16:51
dereckson retitled this revision from to New library to fetch a Mailgun stored message.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: Sandlayth.
dereckson added a task: T1000: Detect builds issues with Docker images.
dereckson updated this revision to Diff 1599.Sep 1 2016, 16:54

Update commit range

dereckson planned changes to this revision.Sep 1 2016, 16:55
dereckson added inline comments.
CHANGELOG.md
8

\n

src/MailgunMessage.php
9

Test me!

dereckson updated this revision to Diff 1600.Sep 1 2016, 17:08
dereckson marked 2 inline comments as done.

Tests, \n

dereckson planned changes to this revision.Sep 1 2016, 17:13
dereckson added inline comments.
src/MailgunMessage.php
100

Not needed, as Client::request will alreadt throw this exception.

dereckson updated this revision to Diff 1601.Sep 1 2016, 17:14

100% unit tests cover

dereckson updated this revision to Diff 1602.Sep 1 2016, 17:20

Client → ClientInterface

Sandlayth accepted this revision.Sep 1 2016, 17:27
Sandlayth edited edge metadata.
This revision is now accepted and ready to land.Sep 1 2016, 17:27
dereckson added a child revision: D640: Add Mailgun support.Sep 1 2016, 19:40
dereckson updated this revision to Diff 1606.Sep 1 2016, 20:44
dereckson edited edge metadata.

abcdefg → abcdef

Closed by commit rKMAILGUNcbdfbd39de48: New library to fetch a Mailgun stored message (authored by dereckson, committed by dereckson). · Explain WhySep 1 2016, 20:47
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
7 lines--
13 lines--
src/
2 lines--
10 lines100%
Loading...
tests/
14 lines--
14 lines--

Diff 1598

View Options

CHANGELOG.md

Loading...
View Options

phpunit.xml

Loading...
View Options

src/MailgunMessage.php

Loading...
View Options

src/MailgunMessageFactory.php

Loading...
View Options

tests/MailgunMessageFactoryTest.php

Loading...
View Options

tests/WithMockHttpClient.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator