Page MenuHomeDevCentral
Differential D697

Format <code> blocks correctly
ClosedPublic
Actions

Authored by dereckson on Nov 6 2016, 23:57.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 08:17
Unknown Object (File)
Sun, Nov 2, 06:16
Unknown Object (File)
Sun, Nov 2, 05:23
Unknown Object (File)
Thu, Oct 30, 09:33
Unknown Object (File)
Thu, Oct 30, 08:58
Unknown Object (File)
Wed, Oct 29, 08:30
Unknown Object (File)
Fri, Oct 24, 09:59
Unknown Object (File)
Thu, Oct 23, 03:35
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rINFRAWWW5ff704ddf661: Format <code> blocks correctly
rSERVERSLOGDESIGN5ff704ddf661: Format <code> blocks correctly
Summary

Log contains code excerpts, so we take care to design them correctly,
especially against primary and secondary background callouts.

Roboto Mono is the font selected for code.

Test Plan

Tested on log front-end client code.

Diff Detail

Repository
rSERVERSLOGDESIGN Servers logs website (design)
Lint
Lint Passed
Unit
No Test Coverage
Branch
D697
Build Status
Buildable 1059
Build 1274: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1750.Nov 6 2016, 23:57
dereckson retitled this revision from to Format <code> blocks correctly.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson accepted this revision.Nov 6 2016, 23:59
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 00:00
dereckson updated this revision to Diff 1753.Nov 7 2016, 00:02
dereckson edited edge metadata.

Rebased against 2226a618ad83.

dereckson updated this revision to Diff 1754.Nov 7 2016, 00:04

Rebased correctly against 2226a618ad83 without server log API client code.

dereckson updated this object.Nov 7 2016, 00:05
Closed by commit rSERVERSLOGDESIGN5ff704ddf661: Format <code> blocks correctly (authored by dereckson, committed by dereckson). · Explain WhyNov 7 2016, 00:05
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
assets/
scss/
20 lines
components/
16 lines
layouts/
2 lines

Diff 1754

View Options

src/assets/scss/_settings.scss

Loading...
View Options

src/assets/scss/components/_layout.scss

Loading...
View Options

src/layouts/default.html

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator