Details
Details
- Reviewers
• spI33n - Commits
- rTASACORAEXP2161f10eb3d7: Reviewers: dereckson
Diff Detail
Diff Detail
- Repository
- rTASACORAEXP Tasacora experimental code
- Lint
No Lint Coverage - Unit
No Test Coverage - Branch
- arcpatch-D8
Event Timeline
Comment Actions
The change in src/testSvgWheelManager.py is perfect.
We have some extra files in the commit:
- .pyc files are compiled files, they should not belong to the repository. In another change, you can submit a .gitignore file with *.pyc as content to avoid that.
- .py~ files are Vim backup files, we could add *~ to .gitignore
About the commit message:
- It should be in English
- Test plan should contain the steps made to test the change (here for example "Run again the script on FreeBSD 10" would be a good test plan description; non trivial changes require more serious tests)
Could you also check other .py files to hunt the other #!/usr/bin/python?
Comment Actions
Il also extracted the .gitignore from this revision and committed as rTASACORAEXPf546d35cd546.