Page MenuHomeDevCentral

Honour Application abstract contract in ReportServiceProvider
ClosedPublic

Authored by dereckson on Dec 28 2016, 03:45.
Tags
None
Referenced Files
F23692852: D771.id1951.diff
Fri, Feb 6, 02:34
F23659215: D771.diff
Thu, Feb 5, 22:40
F23654213: D771.diff
Thu, Feb 5, 21:58
F23590587: D771.diff
Thu, Feb 5, 13:58
Unknown Object (File)
Thu, Feb 5, 03:27
Unknown Object (File)
Wed, Feb 4, 22:14
Unknown Object (File)
Wed, Feb 4, 04:08
Unknown Object (File)
Mon, Feb 2, 06:26
Subscribers

Details

Summary

Laravel Container and so Application classes offer to access services:

  • using the make method in the abstract contract
  • through ArrayAccess in the concrete implementation

We used array access, but documented ReportServiceProvider::register
is happy to accept any \Illuminate\Contracts\Foundation\Application.

To honour this claim, we so switch to use the make method.

This is a follow-up to 6ed92b9a75b8.

This fixes the following phan issue:

app/Providers/ReportServiceProvider.php:21
PhanTypeArraySuspicious
Suspicious array access to \Illuminate\Contracts\Foundation\Application
Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
suspicious-array-access (branched from master)

Event Timeline

dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 11:26
This revision was automatically updated to reflect the committed changes.