Page MenuHomeDevCentral
Differential D805

Fix type issue in XHubSignature::parseSignature
ClosedPublic
Actions

Authored by dereckson on Jan 7 2017, 06:11.
Tags
None
Referenced Files
F7607608: D805.diff
Tue, Apr 29, 15:34
F7562955: D805.id.diff
Mon, Apr 28, 20:21
F7557613: D805.diff
Mon, Apr 28, 18:18
Unknown Object (File)
Mon, Apr 28, 10:03
Unknown Object (File)
Mon, Apr 28, 06:44
Unknown Object (File)
Thu, Apr 24, 23:36
Unknown Object (File)
Wed, Apr 23, 22:59
Unknown Object (File)
Wed, Apr 23, 16:03
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rKERUALDc0e14492852e: Fix type issue in XHubSignature::parseSignature
rKGHc0e14492852e: Fix type issue in XHubSignature::parseSignature
Summary

This fixes the following issue:

Type error: Return value of
Nasqueron\Notifications\Http\Controllers\Gate\GitHubGateController::getSignature()
must be of the type string, null returned in
/src/app/Http/Controllers/Gate/GitHubGateController.php:114

Diff Detail

Repository
rKGH Keruald GitHub
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
type (branched from master)
Build Status
Buildable 1235
Build 1483: arc lint + arc unit

Revision Contents
Changeset List

PathSize
4 lines

Diff 2040

View Options

XHubSignature.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator