Differential D95

Degrade silently bit.ly API call on request failure
ClosedPublic
Actions

Authored by dereckson on Nov 30 2015, 04:45.

Details

Reviewers

dereckson

Maniphest Tasks

T601: Intercept BadResponseException in /lists/replace URI shorten feature

Commits

rTOOLS9ec4ad403649: Degrade silently bit.ly API call on request failure

Summary

If a too long URL is generated by the list replace tool, bit.ly API
throws a 500 error. To prevent this, we degrade silently to a regular
non-short URL mode when this occurs.

Fixes T601.

Test Plan

test with URL provided in bug case

Diff Detail

Repository

rTOOLS Nasqueron Tools

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

T601

Build Status

Buildable 103
Build 103: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 219.Nov 30 2015, 04:45

dereckson added a task: T601: Intercept BadResponseException in /lists/replace URI shorten feature.

dereckson retitled this revision from to Degrade silently bit.ly API call on request failure.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson planned changes to this revision.Nov 30 2015, 04:46

dereckson added inline comments.

lists/replace.php
126	It's not a time out error, but a 500.

More precise comment

Cleaned ommits selection

dereckson accepted this revision.Nov 30 2015, 04:50

dereckson edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2015, 04:50

Closed by commit rTOOLS9ec4ad403649: Degrade silently bit.ly API call on request failure (authored by dereckson, committed by dereckson). · Explain WhyNov 30 2015, 04:51

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lists/

replace.php

6 lines

Diff 219

View Options

Degrade silently bit.ly API call on request failureClosedPublicActions