Bypass message queue when it risks a collision with SIGCHLD.
ClosedPublic
Actions

Authored by dereckson on Dec 19 2015, 17:46.

Details

Reviewers

Maniphest Tasks

T627: Avoid to catch the SIGCHLD signal triggered every five minutes

Commits

rVIPERdb3159301d54: Bypass message queue when it risks a collision with SIGCHLD.
rVIPERSERVdd5b1b408ce3: Bypass message queue when it risks a collision with SIGCHLD.

Summary

This Saturday, we've got SIGCHLD caught by rabbitmq.so at
00:00, 1:00, 1:30, 5:55, 6:55 11:50 and 12:20.

So every 5 minutes, when it's time for SIGCHLD, we avoid to
call mq get.

Fixes T627.

Test Plan

Wait 24h, check if we've still some SIGCHLD.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dereckson updated this revision to Diff 267.Dec 19 2015, 17:46

dereckson retitled this revision from to Tweak notifications.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson added a task: T627: Avoid to catch the SIGCHLD signal triggered every five minutes.

discard r87, this revision is about r88 only

23:40:00 <wearg> [DEBUG] Ignoring SIGCHLD

Would probably interesting to block at 299 too.

dereckson planned changes to this revision.Dec 20 2015, 10:24

299 is interesting too

dereckson mentioned this in T628: exceptions4c: don't intercept SIGCHLD.Dec 20 2015, 11:05

11:00:00 <wearg> [DEBUG] Ignoring SIGCHLD

Not really efficient, but that will do.

This revision is now accepted and ready to land.Dec 25 2015, 18:41

Closed by commit rVIPERSERVdd5b1b408ce3: Bypass message queue when it risks a collision with SIGCHLD. (authored by dereckson). · Explain WhyDec 27 2015, 09:59

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Wearg/

Broker.tcl

8 lines

Diff 268

View Options

Bypass message queue when it risks a collision with SIGCHLD.ClosedPublicActions