Page MenuHomeDevCentral
Differential D111

Bypass message queue when it risks a collision with SIGCHLD.
ClosedPublic
Actions

Authored by dereckson on Dec 19 2015, 17:46.
Tags
None
Referenced Files
F12204870: D111.diff
Mon, Oct 6, 09:11
F12204863: D111.id.diff
Mon, Oct 6, 09:08
F12186734: D111.id270.diff
Mon, Oct 6, 04:00
F12118215: D111.diff
Sun, Oct 5, 11:13
Unknown Object (File)
Wed, Oct 1, 16:47
Unknown Object (File)
Sat, Sep 27, 05:20
Unknown Object (File)
Thu, Sep 25, 00:21
Unknown Object (File)
Wed, Sep 24, 03:19
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T627: Avoid to catch the SIGCHLD signal triggered every five minutes
Commits
rVIPERdb3159301d54: Bypass message queue when it risks a collision with SIGCHLD.
rVIPERSERVdd5b1b408ce3: Bypass message queue when it risks a collision with SIGCHLD.
Summary

This Saturday, we've got SIGCHLD caught by rabbitmq.so at
00:00, 1:00, 1:30, 5:55, 6:55 11:50 and 12:20.

So every 5 minutes, when it's time for SIGCHLD, we avoid to
call mq get.

Fixes T627.

Test Plan

Wait 24h, check if we've still some SIGCHLD.

Diff Detail

Repository
rVIPERSERV ViperServ scripts [legacy Mercurial repo]
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
master (bookmark) on default (branch)
Build Status
Buildable 137
Build 137: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 267.Dec 19 2015, 17:46
dereckson retitled this revision from to Tweak notifications.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson added a task: T627: Avoid to catch the SIGCHLD signal triggered every five minutes.
dereckson updated this revision to Diff 268.Dec 19 2015, 17:49
dereckson retitled this revision from Tweak notifications to Bypass message queue when it risks a collision with SIGCHLD..
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.

discard r87, this revision is about r88 only

dereckson added a comment.Dec 20 2015, 10:21

23:40:00 <wearg> [DEBUG] Ignoring SIGCHLD

Would probably interesting to block at 299 too.

dereckson planned changes to this revision.Dec 20 2015, 10:24
dereckson updated this revision to Diff 270.Dec 20 2015, 10:58
dereckson edited edge metadata.

299 is interesting too

dereckson mentioned this in T628: exceptions4c: don't intercept SIGCHLD.Dec 20 2015, 11:05
dereckson added a comment.Dec 20 2015, 11:07

11:00:00 <wearg> [DEBUG] Ignoring SIGCHLD

dereckson accepted this revision.Dec 25 2015, 18:41
dereckson edited edge metadata.

Not really efficient, but that will do.

This revision is now accepted and ready to land.Dec 25 2015, 18:41
Closed by commit rVIPERSERVdd5b1b408ce3: Bypass message queue when it risks a collision with SIGCHLD. (authored by dereckson). · Explain WhyDec 27 2015, 09:59
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Wearg/
20 lines

Diff 270

View Options

Wearg/Broker.tcl

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator