Page MenuHomeDevCentral
Differential D114

Phabricator notifications now supports repos without any project
ClosedPublic
Actions

Authored by dereckson on Dec 22 2015, 19:57.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 02:49
Unknown Object (File)
Tue, Dec 17, 00:09
Unknown Object (File)
Mon, Dec 16, 23:59
Unknown Object (File)
Thu, Dec 12, 15:36
Unknown Object (File)
Thu, Dec 12, 12:36
Unknown Object (File)
Sun, Dec 8, 04:18
Unknown Object (File)
Fri, Dec 6, 10:04
Unknown Object (File)
Thu, Dec 5, 01:27
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIF03d4d9566c3a: Phabricator notifications now supports repos without any project
Summary

Currently, when a Phabricator payload for a commit comes,
it were assumed there were always projects to fetch.

This takes care of the following exception:

Exception type: ErrorException
Exception message: Undefined property: stdClass::$PHID-CMIT-pq...
In app/Phabricator/PhabricatorStory.php:140

It also solves another small code issue triggering an error.

Test Plan

Phabricator resends failed requests at periodic intervals.

After it has been fixed, Phabricator sends it again.

12:18:20 < Wearg> dereckson created Notifications center.
12:23:24 < Wearg> dereckson set the image for Notifications center to F15185: profile.

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
fix/Phabricator
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 272.Dec 22 2015, 19:57
dereckson retitled this revision from to Phabricator notifications now supports repos without any project.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson accepted this revision.Dec 22 2015, 20:00
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 20:00
Closed by commit rNOTIF03d4d9566c3a: Phabricator notifications now supports repos without any project (authored by dereckson, committed by dereckson). · Explain WhyDec 22 2015, 20:01
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Analyzers/
2 lines
2 lines
Phabricator/
7 lines

Diff 272

View Options

app/Analyzers/PhabricatorGroupMapping.php

Loading...
View Options

app/Analyzers/PhabricatorPayloadAnalyzer.php

Loading...
View Options

app/Phabricator/PhabricatorStory.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator