Page MenuHomeDevCentral

Allow to determine if a node has a role
ClosedPublic

Authored by dereckson on Nov 1 2017, 18:59.
Tags
None
Referenced Files
F3628729: D1146.id2930.diff
Sat, Oct 5, 19:41
F3628728: D1146.id2929.diff
Sat, Oct 5, 19:41
F3628727: D1146.id2928.diff
Sat, Oct 5, 19:41
Unknown Object (File)
Fri, Oct 4, 19:27
Unknown Object (File)
Fri, Oct 4, 19:03
Unknown Object (File)
Fri, Oct 4, 12:20
Unknown Object (File)
Wed, Oct 2, 20:04
Unknown Object (File)
Wed, Oct 2, 20:04
Subscribers
None

Details

Summary

Ref T1275

Test Plan

salt * node.has_role devserver

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
master
Build Status
Buildable 1805
Build 2053: arc lint + arc unit

Event Timeline

dereckson added inline comments.
_modules/node.py
85

'node' virtual returned False: name 'Node' is not defined

dereckson marked an inline comment as done.

s/Node/None

If we return something that would be better

$ pm go ops
$ arc patch D1146
$ salt-call --local node.has_role devserver
local:
    True
$ salt-call --local node.has_role devserverz
local:
    False
This revision is now accepted and ready to land.Nov 1 2017, 21:40
This revision was automatically updated to reflect the committed changes.