Page MenuHomeDevCentral

Allow to determine if a node has a role
ClosedPublic

Authored by dereckson on Nov 1 2017, 18:59.
Tags
None
Referenced Files
F43349594: D1146.id2930.diff
Wed, Aug 12, 02:53
F43240490: D1146.id2928.diff
Tue, Aug 11, 14:23
F43212617: D1146.diff
Tue, Aug 11, 10:46
Unknown Object (File)
Sun, Aug 2, 12:09
Unknown Object (File)
Fri, Jul 31, 21:33
Unknown Object (File)
Mon, Jul 20, 11:48
Unknown Object (File)
Mon, Jul 20, 01:19
Unknown Object (File)
Fri, Jul 17, 22:31
Subscribers
None

Details

Summary

Ref T1275

Test Plan

salt * node.has_role devserver

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
master
Build Status
Buildable 1807
Build 2055: arc lint + arc unit

Event Timeline

dereckson added inline comments.
_modules/node.py
85

'node' virtual returned False: name 'Node' is not defined

dereckson marked an inline comment as done.

s/Node/None

If we return something that would be better

$ pm go ops
$ arc patch D1146
$ salt-call --local node.has_role devserver
local:
    True
$ salt-call --local node.has_role devserverz
local:
    False
This revision is now accepted and ready to land.Nov 1 2017, 21:40
This revision was automatically updated to reflect the committed changes.