Page MenuHomeDevCentral

Allow to determine if a node has a role
ClosedPublic

Authored by dereckson on Nov 1 2017, 18:59.
Tags
None
Referenced Files
F12472680: D1146.diff
Fri, Nov 7, 15:05
F12469779: D1146.id2929.diff
Fri, Nov 7, 13:21
F12459788: D1146.id2928.diff
Fri, Nov 7, 04:47
F12458068: D1146.diff
Fri, Nov 7, 03:39
Unknown Object (File)
Thu, Nov 6, 20:41
Unknown Object (File)
Wed, Nov 5, 16:52
Unknown Object (File)
Mon, Nov 3, 06:58
Unknown Object (File)
Sun, Nov 2, 23:36
Subscribers
None

Details

Summary

Ref T1275

Test Plan

salt * node.has_role devserver

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
master
Build Status
Buildable 1807
Build 2055: arc lint + arc unit

Event Timeline

dereckson added inline comments.
_modules/node.py
85

'node' virtual returned False: name 'Node' is not defined

dereckson marked an inline comment as done.

s/Node/None

If we return something that would be better

$ pm go ops
$ arc patch D1146
$ salt-call --local node.has_role devserver
local:
    True
$ salt-call --local node.has_role devserverz
local:
    False
This revision is now accepted and ready to land.Nov 1 2017, 21:40
This revision was automatically updated to reflect the committed changes.