Page MenuHomeDevCentral

Allow to determine if a node has a role
ClosedPublic

Authored by dereckson on Nov 1 2017, 18:59.
Tags
None
Referenced Files
F14790423: D1146.id2927.diff
Sun, Nov 30, 16:08
F14716722: D1146.id2928.diff
Sun, Nov 30, 05:24
F14675354: D1146.id2930.diff
Sat, Nov 29, 23:31
Unknown Object (File)
Wed, Nov 26, 20:53
Unknown Object (File)
Tue, Nov 25, 07:59
Unknown Object (File)
Mon, Nov 24, 08:27
Unknown Object (File)
Mon, Nov 24, 08:26
Unknown Object (File)
Fri, Nov 21, 20:51
Subscribers
None

Details

Summary

Ref T1275

Test Plan

salt * node.has_role devserver

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
master
Build Status
Buildable 1807
Build 2055: arc lint + arc unit

Event Timeline

dereckson added inline comments.
_modules/node.py
85

'node' virtual returned False: name 'Node' is not defined

dereckson marked an inline comment as done.

s/Node/None

If we return something that would be better

$ pm go ops
$ arc patch D1146
$ salt-call --local node.has_role devserver
local:
    True
$ salt-call --local node.has_role devserverz
local:
    False
This revision is now accepted and ready to land.Nov 1 2017, 21:40
This revision was automatically updated to reflect the committed changes.