Page MenuHomeDevCentral
Differential D1270

Remove core.hostnames pillar
ClosedPublic
Actions

Authored by dereckson on Dec 1 2017, 12:11.
Tags
None
Referenced Files
F3931362: D1270.id.diff
Sun, Dec 22, 18:30
Unknown Object (File)
Tue, Dec 17, 13:47
Unknown Object (File)
Mon, Dec 16, 20:06
Unknown Object (File)
Mon, Dec 16, 19:41
Unknown Object (File)
Fri, Dec 13, 16:14
Unknown Object (File)
Fri, Dec 13, 12:43
Unknown Object (File)
Thu, Dec 12, 13:05
Unknown Object (File)
Sat, Dec 7, 20:01
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS336e12bd0071: Remove core.hostnames pillar
Summary

b112ea76 introduced nodes definition, including hostnames,
so it's possible to directly get the hostname from the node
entry instead of a dedicated pillar entry.

This change partially reverts b88a308fec2d.
This change reverts 866436e489cd.

Test Plan

salt * state.apply roles/core/hostname test=True

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
kill-pillar-hostname
Build Status
Buildable 2019
Build 2267: arc lint + arc unit

Event Timeline

dereckson created this revision.Dec 1 2017, 12:11
Harbormaster completed remote builds in B2019: Diff 3265.Dec 1 2017, 12:11
dereckson accepted this revision.Dec 1 2017, 12:12
dereckson edited the summary of this revision. (Show Details)
dereckson edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Dec 1 2017, 12:12
Closed by commit rOPS336e12bd0071: Remove core.hostnames pillar (authored by dereckson). · Explain WhyDec 1 2017, 12:13
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pillar/
core/
1 line
roles/
core/
hostname/
2 lines

Diff 3265

View Options

pillar/core/hostnames.sls

Loading...
View Options

pillar/top.sls

Loading...
View Options

roles/core/hostname/init.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator