Page MenuHomeDevCentral
Differential D157

Filesystem abstraction for storage
ClosedPublic
Actions

Authored by dereckson on Jan 2 2016, 22:25.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 4, 23:16
Unknown Object (File)
Sat, Aug 29, 19:55
Unknown Object (File)
Sat, Aug 29, 13:07
Unknown Object (File)
Sun, Aug 23, 09:09
Unknown Object (File)
Sun, Aug 23, 04:57
Unknown Object (File)
Sat, Aug 22, 07:02
Unknown Object (File)
Sat, Aug 22, 02:57
Unknown Object (File)
Sat, Aug 22, 02:19
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIF8e3ebcf2aa07: Filesystem abstraction for storage
Summary

Use the Storage facace for fileystem abstraction.

Removed 'app/' from default configuration value.

file_exists → Storage::has
file_get_contents → Storage::get

Test Plan
  • php artisan phabricator:projectsmap
  • Test a GitHub payload request
  • Test a Phabricator payload request

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
filesystem
Build Status
Buildable 198
Build 198: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 374.Jan 2 2016, 22:25
dereckson retitled this revision from to Filesystem abstraction for storage.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson accepted this revision.Jan 2 2016, 22:26
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2016, 22:26
Closed by commit rNOTIF8e3ebcf2aa07: Filesystem abstraction for storage (authored by dereckson, committed by dereckson). · Explain WhyJan 2 2016, 22:26
This revision was automatically updated to reflect the committed changes.
dereckson mentioned this in D160: Services.Jan 2 2016, 23:43
dereckson mentioned this in rNOTIF2be5bb93d3bf: Services.Jan 2 2016, 23:47

Revision Contents
Changeset List

PathSize
app/
Analyzers/
5 lines
5 lines
Console/
Commands/
3 lines
Http/
Controllers/
Gate/
3 lines
Phabricator/
4 lines
config/
6 lines

Diff 374

View Options

app/Analyzers/GitHubPayloadAnalyzer.php

Loading...
View Options

app/Analyzers/PhabricatorPayloadAnalyzer.php

Loading...
View Options

app/Console/Commands/PhabricatorGetProjectsMap.php

Loading...
View Options

app/Http/Controllers/Gate/GateController.php

Loading...
View Options

app/Phabricator/PhabricatorAPI.php

Loading...
View Options

config/services.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator