Page MenuHomeDevCentral
Differential D164

PhabricatorAPI: improve code documentation, scope review
ClosedPublic
Actions

Authored by dereckson on Jan 4 2016, 19:42.
Tags
None
Referenced Files
F10827025: D164.id.diff
Mon, Jul 28, 02:07
Unknown Object (File)
Fri, Jul 18, 20:48
Unknown Object (File)
Tue, Jul 15, 03:08
Unknown Object (File)
Mon, Jul 14, 09:12
Unknown Object (File)
Sun, Jul 13, 06:42
Unknown Object (File)
Fri, Jul 11, 15:12
Unknown Object (File)
Wed, Jul 9, 19:03
Unknown Object (File)
Sat, Jul 5, 19:15
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIF73d3e926e543: PhabricatorAPI: improve code documentation, scope review
Summary

Code documentation

  • Array type is set to 'array' and not 'Array' for @return @var and @param

Scope review

Some methods are now now private: fetchFromAPI, isCached

Test Plan

php artisan phabricator:projectsmap (test requires D165).

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
private
Build Status
Buildable 206
Build 206: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 391.Jan 4 2016, 19:42
dereckson retitled this revision from to Improve code documentation.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson planned changes to this revision.Jan 4 2016, 19:42
dereckson edited the test plan for this revision. (Show Details)
dereckson retitled this revision from Improve code documentation to PhabricatorAPI: improve code documentation, scope review.
dereckson updated this object.
dereckson edited edge metadata.

As we've already two changes, let's add also the doc one.

dereckson updated this revision to Diff 392.Jan 4 2016, 19:46
dereckson edited edge metadata.

+one commit, Improve PhabricatorAPI code documentation

dereckson accepted this revision.Jan 4 2016, 19:46
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2016, 19:46
Closed by commit rNOTIF73d3e926e543: PhabricatorAPI: improve code documentation, scope review (authored by dereckson, committed by dereckson). · Explain WhyJan 4 2016, 19:49
This revision was automatically updated to reflect the committed changes.
dereckson edited the test plan for this revision. (Show Details)Jan 4 2016, 20:21
dereckson edited edge metadata.

Revision Contents
Changeset List

PathSize
app/
Phabricator/
2 lines
6 lines

Diff 391

View Options

app/Phabricator/PhabricatorStory.php

Loading...
View Options

app/Phabricator/ProjectsMap.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator