Page MenuHomeDevCentral

PhabricatorAPI: improve code documentation, scope review
ClosedPublic

Authored by dereckson on Jan 4 2016, 19:42.
Tags
None
Referenced Files
F56608639: D164.id393.diff
Sat, Nov 7, 16:03
F56416298: D164.id392.diff
Thu, Nov 5, 23:38
F56407492: D164.id391.diff
Thu, Nov 5, 21:31
F56334607: D164.id.diff
Thu, Nov 5, 03:57
F56278409: D164.id393.diff
Wed, Nov 4, 13:22
F56276044: D164.id392.diff
Wed, Nov 4, 12:47
F56275986: D164.id391.diff
Wed, Nov 4, 12:46
F56239696: D164.id391.diff
Wed, Nov 4, 02:56
Subscribers
None

Details

Summary

Code documentation

  • Array type is set to 'array' and not 'Array' for @return @var and @param

Scope review

Some methods are now now private: fetchFromAPI, isCached

Test Plan

php artisan phabricator:projectsmap (test requires D165).

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
private
Build Status
Buildable 207
Build 207: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Improve code documentation.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited the test plan for this revision. (Show Details)
dereckson retitled this revision from Improve code documentation to PhabricatorAPI: improve code documentation, scope review.
dereckson updated this object.
dereckson edited edge metadata.

As we've already two changes, let's add also the doc one.

dereckson edited edge metadata.

+one commit, Improve PhabricatorAPI code documentation

dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2016, 19:46
This revision was automatically updated to reflect the committed changes.
dereckson edited edge metadata.