Paths

Table of Contentst

Differential D164

PhabricatorAPI: improve code documentation, scope review
ClosedPublic
Actions

Authored by dereckson on Jan 4 2016, 19:42.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF73d3e926e543: PhabricatorAPI: improve code documentation, scope review

Summary

Code documentation

Array type is set to 'array' and not 'Array' for @return @var and @param

Scope review

Some methods are now now private: fetchFromAPI, isCached

Test Plan

php artisan phabricator:projectsmap (test requires D165).

Diff Detail

Repository

rNOTIF Notifications center

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

private

Build Status

Buildable 207
Build 207: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 391.Jan 4 2016, 19:42

dereckson retitled this revision from to Improve code documentation.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

As we've already two changes, let's add also the doc one.

+one commit, Improve PhabricatorAPI code documentation

dereckson accepted this revision.Jan 4 2016, 19:46

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 4 2016, 19:46

Closed by commit rNOTIF73d3e926e543: PhabricatorAPI: improve code documentation, scope review (authored by dereckson, committed by dereckson). · Explain WhyJan 4 2016, 19:49

This revision was automatically updated to reflect the committed changes.

dereckson edited the test plan for this revision. (Show Details)Jan 4 2016, 20:21

dereckson edited edge metadata.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

ProjectsMap.php

22 lines

Diff 392

View Options

app/Phabricator/ProjectsMap.php

PhabricatorAPI: improve code documentation, scope reviewClosedPublicActions