Page MenuHomeDevCentral
Differential D1625

Rename RemoteAddress::getOne to getClientAddress
ClosedPublic
Actions

Authored by dereckson on Apr 21 2018, 01:13.
Tags
None
Referenced Files
F3923498: D1625.id4148.diff
Sat, Dec 21, 08:08
F3923066: D1625.diff
Sat, Dec 21, 05:52
F3920532: D1625.id.diff
Fri, Dec 20, 16:15
F3920470: D1625.diff
Fri, Dec 20, 15:53
Unknown Object (File)
Thu, Dec 12, 03:08
Unknown Object (File)
Tue, Dec 10, 02:26
Unknown Object (File)
Wed, Nov 27, 12:35
Unknown Object (File)
Sat, Nov 23, 15:03
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rKOTd5d3fe98e58c: Rename RemoteAddress::getOne to getClientAddress
Summary

“get one” asks a second question: “which one?”

The answer is the first one, ie “the client IP”, per future RFC 7239.

This is a follow-up for change b7683f8d6cf8.

Test Plan

Run tests to ensure it's correctly renamed everywhere

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Apr 21 2018, 01:13
dereckson created this revision.
Harbormaster completed remote builds in B2550: Diff 4148.Apr 21 2018, 01:13
dereckson accepted this revision.Apr 21 2018, 01:13
This revision is now accepted and ready to land.Apr 21 2018, 01:13
Closed by commit rKOTd5d3fe98e58c: Rename RemoteAddress::getOne to getClientAddress (authored by dereckson). · Explain WhyApr 21 2018, 01:13
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
HTTP/
Requests/
2 lines
2 lines
tests/
HTTP/
Requests/
10 lines

Diff 4149

View Options

src/HTTP/Requests/RemoteAddress.php

Loading...
View Options

src/HTTP/Requests/WithRemoteAddress.php

Loading...
View Options

tests/HTTP/Requests/RemoteAddressTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator