Support other countable legacy types
ClosedPublic
Actions

Authored by dereckson on May 15 2018, 21:00.

Tags

None

Referenced Files

	F12416897: D1640.id4185.diff
	Tue, Nov 4, 02:59

	F12416896: D1640.id4184.diff
	Tue, Nov 4, 02:59

	F12413534: D1640.diff
	Mon, Nov 3, 19:24

	Unknown Object (File)
	Sun, Nov 2, 09:16

	Unknown Object (File)
	Fri, Oct 31, 10:40

	Unknown Object (File)
	Wed, Oct 29, 09:49

	Unknown Object (File)
	Thu, Oct 23, 14:52

	Unknown Object (File)
	Tue, Oct 21, 12:33

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOTa65de8f3d3b3: Support other countable legacy types

Summary

Per https://github.com/Ayesh/is_countable-polyfill,
SimpleXMLElement and ResourceBundle are countable too.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Tests Passed

Branch

countable

Build Status

Buildable 2571
Build 2819: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 15 2018, 21:00

dereckson created this revision.

Harbormaster completed remote builds in B2571: Diff 4184.May 15 2018, 21:00

dereckson accepted this revision.May 16 2018, 20:07

This revision is now accepted and ready to land.May 16 2018, 20:07

Closed by commit rKOTa65de8f3d3b3: Support other countable legacy types (authored by dereckson). · Explain WhyMay 16 2018, 20:09

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

Collections/

TraversableUtilities.php

16 lines

Diff 4184

View Options

src/Collections/TraversableUtilities.php

Support other countable legacy typesClosedPublicActions