Support other countable legacy types
ClosedPublic
Actions

Authored by dereckson on May 15 2018, 21:00.

Tags

None

Referenced Files

	F12244077: D1640.id4184.diff
	Fri, Oct 10, 16:23

	F12243529: D1640.diff
	Fri, Oct 10, 14:12

	Unknown Object (File)
	Tue, Oct 7, 01:48

	Unknown Object (File)
	Sat, Sep 27, 01:43

	Unknown Object (File)
	Fri, Sep 26, 12:49

	Unknown Object (File)
	Wed, Sep 17, 23:28

	Unknown Object (File)
	Sun, Sep 14, 10:18

	Unknown Object (File)
	Sun, Sep 14, 05:45

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOTa65de8f3d3b3: Support other countable legacy types

Summary

Per https://github.com/Ayesh/is_countable-polyfill,
SimpleXMLElement and ResourceBundle are countable too.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.May 15 2018, 21:00

dereckson created this revision.

Harbormaster completed remote builds in B2571: Diff 4184.May 15 2018, 21:00

dereckson accepted this revision.May 16 2018, 20:07

This revision is now accepted and ready to land.May 16 2018, 20:07

Closed by commit rKOTa65de8f3d3b3: Support other countable legacy types (authored by dereckson). · Explain WhyMay 16 2018, 20:09

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

Collections/

TraversableUtilities.php

16 lines

Diff 4185

View Options

src/Collections/TraversableUtilities.php

Support other countable legacy typesClosedPublicActions