Page MenuHomeDevCentral

Tests for ActionsReport
ClosedPublic

Authored by dereckson on Jan 8 2016, 13:40.
Tags
None
Referenced Files
F3911393: D176.diff
Thu, Dec 19, 02:40
Unknown Object (File)
Sat, Dec 14, 18:53
Unknown Object (File)
Fri, Dec 13, 08:05
Unknown Object (File)
Thu, Dec 12, 22:49
Unknown Object (File)
Sun, Dec 8, 17:23
Unknown Object (File)
Sun, Dec 8, 01:20
Unknown Object (File)
Fri, Dec 6, 17:12
Unknown Object (File)
Wed, Dec 4, 20:20
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIF72ee1dfcacff: Tests for ActionsReport
Summary

ActionsReport is now fully tested.

Test Plan

phpunit

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
ActionsReport
Build Status
Buildable 225
Build 225: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to WIP: Tests for ActionsReport.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.

More tests.

This will be full coverage after a refactoring at D178
where we move the rendering operation to the controller.

dereckson retitled this revision from WIP: Tests for ActionsReport to Tests for ActionsReport.Jan 8 2016, 15:38
dereckson edited edge metadata.
build/logs/coverage/index.xml
[...]
<directory name="Actions">
  <totals>
    <lines total="226" comments="117" code="109" executable="29" executed="29" percent="100.00%"/>
    <methods count="11" tested="11" percent="100.00%"/>
    <functions count="0" tested="0" percent=""/>
    <classes count="5" tested="5" percent="100.00%"/>
    <traits count="0" tested="0" percent=""/>
  </totals>
  [...]
</directory>
[...]

Removed response code logic per D178.

dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 16:08
This revision was automatically updated to reflect the committed changes.

Code coverage jumped from 14% to 16% after this change.