Page MenuHomeDevCentral

Refactor Services as a Facade to a more generic Services class
ClosedPublic

Authored by dereckson on Jan 8 2016, 19:41.
Tags
None
Referenced Files
F7108323: D180.diff
Sun, Apr 20, 20:09
F7078701: D180.id428.diff
Sun, Apr 20, 08:24
Unknown Object (File)
Sat, Apr 19, 21:43
Unknown Object (File)
Sat, Apr 19, 17:59
Unknown Object (File)
Sat, Apr 19, 17:45
Unknown Object (File)
Sat, Apr 19, 08:49
Unknown Object (File)
Sat, Apr 19, 07:52
Unknown Object (File)
Sat, Apr 19, 07:05
Subscribers
None

Details

Summary

Currently, Services were a bag of static methods to read
credentials.json.

We now provide:

  • a generic and autonomous Services class
  • a Service class to represent a credentials.json entry
  • a services provider to register our application instance of Services
  • a Services facade, as a drop-in substitute for the former Services
Test Plan

Send a payload request.

Run commands php artisan config:show and php artisan phabricator:projectsmap.

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
services-provider
Build Status
Buildable 227
Build 227: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Refactor Services as a Facade to a more generic Services class.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.

Dead code in GateController

dereckson edited edge metadata.

rm dead code

dereckson added inline comments.
app/Services/Services.php
16

To initialize?

16

Could it be private?

22

Dead constructor.

dereckson marked 3 inline comments as done.

Improve Services class

app/Services/Services.php
16

No it couldn't, per JsonMapper.

dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 19:55
This revision was automatically updated to reflect the committed changes.