Improve check-letsencrypt-certificates Python code
ClosedPublic
Actions

Authored by dereckson on Sep 9 2018, 08:23.

Tags

None

Referenced Files

	F7557039: D1697.diff
	Mon, Apr 28, 18:05

	Unknown Object (File)
	Sat, Apr 26, 01:40

	Unknown Object (File)
	Fri, Apr 25, 17:10

	Unknown Object (File)
	Fri, Apr 25, 13:36

	Unknown Object (File)
	Thu, Apr 24, 18:09

	Unknown Object (File)
	Wed, Apr 23, 00:41

	Unknown Object (File)
	Mon, Apr 21, 18:53

	Unknown Object (File)
	Thu, Apr 17, 09:59

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rOPS2666706e3aad: Improve check-letsencrypt-certificates Python code

Summary

port to Python 3
use snake_case for method names and local variables
use _ instead of an unused variable name

Test Plan

flake8

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

improve-python (branched from master)

Build Status

Buildable 2649
Build 2897: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 9 2018, 08:23

dereckson created this revision.

Harbormaster completed remote builds in B2649: Diff 4317.Sep 9 2018, 08:23

dereckson accepted this revision.Sep 9 2018, 08:25

This revision is now accepted and ready to land.Sep 9 2018, 08:25

Closed by commit rOPS2666706e3aad: Improve check-letsencrypt-certificates Python code (authored by dereckson). · Explain WhySep 9 2018, 08:25

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

byTasks/

HTTP/

check-letsencrypt-certificates

53 lines

Diff 4317

View Options

scripts/byTasks/HTTP/check-letsencrypt-certificates

Improve check-letsencrypt-certificates Python codeClosedPublicActions