[Channel] Ensure we've a video title before print it
ClosedPublic
Actions

Authored by dereckson on Jan 9 2016, 01:34.

Details

Reviewers

Commits

rVIPER4f152124f6da: [Channel] Ensure we've a video title before print it
rVIPERSERVf089807056f4: [Channel] Ensure we've a video title before print it

Summary

Sometimes, a video from Vimeo doesn't have a title.

Before, "PRIVMSG #channel :" were sent to the IRC server, with
an extraneous command sent to the server.

With D166 and a new prefix, we had a "[Vid] " line printed.

We now check the length of the video title.

Issue reported by popolon.

Test Plan

Tested on Freenode #fauve.

Diff Detail

Repository

rVIPERSERV ViperServ scripts [legacy Mercurial repo]

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

vimeo-fix (bookmark) on default (branch)

Build Status

Buildable 239
Build 239: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 452.Jan 9 2016, 01:34

dereckson retitled this revision from to [Channel] Ensure we've a video title before print it.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jan 9 2016, 01:35

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 9 2016, 01:35

Closed by commit rVIPERSERVf089807056f4: [Channel] Ensure we've a video title before print it (authored by dereckson). · Explain WhyJan 9 2016, 01:49

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Daeghrefn/

Channel.tcl

2 lines

Diff 452

View Options

[Channel] Ensure we've a video title before print itClosedPublicActions