Page MenuHomeDevCentral
Differential D1926

Always set an aliases value to pass to nginx config template
ClosedPublic
Actions

Authored by dereckson on Oct 15 2018, 12:33.
Tags
None
Referenced Files
F3755867: D1926.id4866.diff
Mon, Nov 18, 18:25
Unknown Object (File)
Sun, Nov 10, 08:59
Unknown Object (File)
Thu, Oct 31, 17:33
Unknown Object (File)
Wed, Oct 30, 13:06
Unknown Object (File)
Mon, Oct 21, 04:15
Unknown Object (File)
Sun, Oct 20, 21:36
Unknown Object (File)
Sun, Oct 20, 05:45
Unknown Object (File)
Sun, Oct 20, 05:45
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS4cac446f1c3d: Always set an aliases value to pass to nginx config template
Summary

When a container doesn't have any alias for hostname,
an empty string is passed to the nginx configuration template.

This is a follow-up for af0a1983.

Test Plan

Run salt equatower state.apply roles/paas-docker/nginx/config
then look the Phabricator containers vhosts (only DevCentral has aliases).

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Oct 15 2018, 12:33
dereckson created this revision.
Harbormaster completed remote builds in B2994: Diff 4865.Oct 15 2018, 12:33
dereckson updated this revision to Diff 4866.Oct 15 2018, 12:37

Use Jinja2 filter to avoid if/else block

Harbormaster completed remote builds in B2995: Diff 4866.Oct 15 2018, 12:37
dereckson accepted this revision.Oct 15 2018, 12:39
dereckson retitled this revision from Explicitly give a null value to aliases when there isn't any to Always set an aliases value to pass to nginx config template.
dereckson edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Oct 15 2018, 12:39
Closed by commit rOPS4cac446f1c3d: Always set an aliases value to pass to nginx config template (authored by dereckson). · Explain WhyOct 15 2018, 12:39
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
roles/
paas-docker/
nginx/
4 lines

Diff 4867

View Options

roles/paas-docker/nginx/config.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator