Page MenuHomeDevCentral
Differential D1968

Serve logo footer from assets
ClosedPublic
Actions

Authored by dereckson on Oct 30 2018, 14:55.
Tags
None
Referenced Files
F3746060: D1968.id.diff
Fri, Nov 15, 18:21
F3744954: D1968.id.diff
Fri, Nov 15, 10:24
Unknown Object (File)
Sun, Nov 10, 16:11
Unknown Object (File)
Sun, Nov 10, 08:46
Unknown Object (File)
Sun, Nov 10, 05:01
Unknown Object (File)
Sat, Nov 9, 08:05
Unknown Object (File)
Fri, Nov 8, 09:11
Unknown Object (File)
Fri, Nov 8, 09:11
View All Files
Subscribers
None

Details

Reviewers
dereckson
ledesillusionniste
Commits
rINFRAWWW1c2d50cb8e8e: Serve logo footer from assets
Summary

It seems the footer has been adapted from the tools.nasqueron.org's one.

This logo is available as a static resource in assets. subdomain.

That's a more suitable source, as tools. is served by a back-end server,
and as such can be unreacheable for maintenance.

Test Plan

Hashes of the two logos match.

Hash from tools

$ wget https://tools.nasqueron.org/images/Nasqueron.png
$ identify Nasqueron.png
Nasqueron.png PNG 133x131 133x131+0+0 8-bit sRGB 1516B 0.000u 0:00.007
$ optipng -o7 Nasqueron.png
** Processing: Nasqueron.png
...
$ md5 Nasqueron.png                                                                                                                                      
MD5 (Nasqueron.png) = af5efed202464d635e63135e98b2ab23

Hash from assets

$ cd /home/dereckson/dev/nasqueron/assets
$ md5 logos/logo-main-133px.png
MD5 (logos/logo-main-133px.png) = af5efed202464d635e63135e98b2ab23

Diff Detail

Repository
rSERVERSLOGDESIGN Servers logs website (design)
Lint
Lint Passed
Unit
No Test Coverage
Branch
logo-source (branched from master)
Build Status
Buildable 3067
Build 3315: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 30 2018, 14:55
dereckson created this revision.
Harbormaster completed remote builds in B3067: Diff 4974.Oct 30 2018, 14:55
dereckson accepted this revision.Oct 30 2018, 14:55
This revision is now accepted and ready to land.Oct 30 2018, 14:55
ledesillusionniste accepted this revision.Oct 30 2018, 14:56
dereckson edited the test plan for this revision. (Show Details)Oct 30 2018, 14:57
Closed by commit rINFRAWWW1c2d50cb8e8e: Serve logo footer from assets (authored by dereckson). · Explain WhyOct 30 2018, 15:05
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
partials/
2 lines

Diff 4974

View Options

src/partials/footer.html

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator