Differential D2028

Fix arguments order
ClosedPublic
Actions

Authored by dereckson on Nov 16 2018, 17:18.

Tags

None

Referenced Files

	F12459474: D2028.diff
	Fri, Nov 7, 04:35

	Unknown Object (File)
	Fri, Oct 31, 04:25

	Unknown Object (File)
	Tue, Oct 28, 06:05

	Unknown Object (File)
	Tue, Oct 28, 06:05

	Unknown Object (File)
	Tue, Oct 28, 05:16

	Unknown Object (File)
	Mon, Oct 27, 03:45

	Unknown Object (File)
	Mon, Oct 27, 03:45

	Unknown Object (File)
	Mon, Oct 27, 02:55

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rOPS3d0a77867bfa: Fix arguments order

Summary

As the queue is extended to the left, arguments are in reverse order.

Test Plan

Tested with a command with multiple arguments

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

shell (branched from master)

Build Status

Buildable 3168
Build 3416: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Nov 16 2018, 17:18

dereckson created this revision.

Harbormaster completed remote builds in B3168: Diff 5129.Nov 16 2018, 17:18

dereckson accepted this revision.Dec 9 2018, 12:23

This revision is now accepted and ready to land.Dec 9 2018, 12:23

Closed by commit rOPS3d0a77867bfa: Fix arguments order (authored by dereckson). · Explain WhyDec 9 2018, 12:27

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

devserver/

userland-software/

files/

shell.py

1 line

Diff 5129

View Options

roles/devserver/userland-software/files/shell.py

Fix arguments orderClosedPublicActions