Paths

Table of Contentst

Differential D2064

Fix version regex
ClosedPublic
Actions

Authored by dereckson on Apr 22 2019, 08:03.

Details

Reviewers

dereckson

Commits

rSCLb766ce7a240b: Fix version regex

Summary

Allow to use version pinning with the multiline output
of shellcheck --version.

Test Plan

arc lint --everything

Diff Detail

Repository

rSCL ShellCheck linter for Arcanist

Lint

Lint Passed

Unit

No Test Coverage

Branch

dereka/fix-version-check

Build Status

Buildable 3215
Build 3464: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 22 2019, 08:03

dereckson created this revision.

Harbormaster completed remote builds in B3215: Diff 5206.Apr 22 2019, 08:03

dereckson accepted this revision.Apr 22 2019, 08:04

This revision is now accepted and ready to land.Apr 22 2019, 08:04

Can't repro directly through arc lint interaction the issue.

Probably best to add a unit test.

Without the fix

$ arc unit --everything
   FAIL  ArcanistShellCheckLinterTestCase::testGetVersion
Assertion failed, expected 'false' (at ArcanistShellCheckLinterTestCase.php:9): The version can't be extracted from the binary output.

With the fix

$ arc unit
   PASS   35ms★ ArcanistShellCheckLinterTestCase::testGetVersion

Adding unit tests

Harbormaster completed remote builds in B3216: Diff 5207.Apr 22 2019, 08:30

dereckson accepted this revision.Apr 22 2019, 08:30

Closed by commit rSCLb766ce7a240b: Fix version regex (authored by Derek Argueta <dereka@pinterest.com>, committed by dereckson). · Explain WhyApr 22 2019, 08:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lint/

linter/

ArcanistShellCheckLinter.php

2 lines

Diff 5206

View Options

lint/linter/ArcanistShellCheckLinter.php

Fix version regexClosedPublicActions