Allow to use version pinning with the multiline output
of shellcheck --version.
Details
Details
- Reviewers
dereckson - Commits
- rSCLb766ce7a240b: Fix version regex
arc lint --everything
Diff Detail
Diff Detail
- Repository
- rSCL ShellCheck linter for Arcanist
- Lint
Lint Passed - Unit
Tests Passed - Branch
- dereka/fix-version-check
- Build Status
Buildable 3216 Build 3465: arc lint + arc unit
Event Timeline
Comment Actions
Can't repro directly through arc lint interaction the issue.
Probably best to add a unit test.
Comment Actions
Without the fix
$ arc unit --everything FAIL ArcanistShellCheckLinterTestCase::testGetVersion Assertion failed, expected 'false' (at ArcanistShellCheckLinterTestCase.php:9): The version can't be extracted from the binary output.
With the fix
$ arc unit PASS 35ms★ ArcanistShellCheckLinterTestCase::testGetVersion