Page MenuHomeDevCentral
Differential D2064

Fix version regex
ClosedPublic
Actions

Authored by dereckson on Apr 22 2019, 08:03.
Tags
None
Referenced Files
F12412545: D2064.id5206.diff
Mon, Nov 3, 17:09
Unknown Object (File)
Mon, Nov 3, 02:18
Unknown Object (File)
Sun, Nov 2, 08:34
Unknown Object (File)
Sat, Nov 1, 07:55
Unknown Object (File)
Wed, Oct 29, 09:36
Unknown Object (File)
Sun, Oct 26, 18:00
Unknown Object (File)
Fri, Oct 24, 11:16
Unknown Object (File)
Tue, Oct 21, 18:05
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rSCLb766ce7a240b: Fix version regex
Summary

Allow to use version pinning with the multiline output
of shellcheck --version.

Test Plan

arc lint --everything

Diff Detail

Repository
rSCL ShellCheck linter for Arcanist
Lint
Lint Passed
Unit
Tests Passed
Branch
dereka/fix-version-check
Build Status
Buildable 3216
Build 3465: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 22 2019, 08:03
dereckson created this revision.
Harbormaster completed remote builds in B3215: Diff 5206.Apr 22 2019, 08:03
dereckson accepted this revision.Apr 22 2019, 08:04
This revision is now accepted and ready to land.Apr 22 2019, 08:04
dereckson added a comment.EditedApr 22 2019, 08:08

Can't repro directly through arc lint interaction the issue.

Probably best to add a unit test.

dereckson added a comment.EditedApr 22 2019, 08:27

Without the fix

$ arc unit --everything
   FAIL  ArcanistShellCheckLinterTestCase::testGetVersion
Assertion failed, expected 'false' (at ArcanistShellCheckLinterTestCase.php:9): The version can't be extracted from the binary output.

With the fix

$ arc unit
   PASS   35ms★ ArcanistShellCheckLinterTestCase::testGetVersion
dereckson updated this revision to Diff 5207.Apr 22 2019, 08:30

Adding unit tests

Harbormaster completed remote builds in B3216: Diff 5207.Apr 22 2019, 08:30
dereckson accepted this revision.Apr 22 2019, 08:30
Closed by commit rSCLb766ce7a240b: Fix version regex (authored by Derek Argueta <dereka@pinterest.com>, committed by dereckson). · Explain WhyApr 22 2019, 08:32
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5207

View Options

.arcconfig

Loading...
View Options

.arcunit

Loading...
View Options

__phutil_library_map__.php

Loading...
View Options

lint/linter/ArcanistShellCheckLinter.php

Loading...
View Options

lint/linter/__tests__/ArcanistShellCheckLinterTestCase.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator