Differential D2276

Provide a base64 encoder compatible with URLs
ClosedPublic
Actions

Authored by dereckson on Mar 11 2020, 00:18.

Tags

None

Referenced Files

	F11724187: D2276.id5733.diff
	Tue, Sep 16, 13:15

	F11724103: D2276.id5734.diff
	Tue, Sep 16, 13:03

	F11723641: D2276.diff
	Tue, Sep 16, 10:50

	Unknown Object (File)
	Mon, Sep 15, 08:15

	Unknown Object (File)
	Sat, Sep 13, 18:23

	Unknown Object (File)
	Sat, Sep 13, 18:16

	Unknown Object (File)
	Mon, Sep 8, 10:48

	Unknown Object (File)
	Sun, Sep 7, 20:53

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1609: Generate n characters string from m bits

Commits

rKOTfd8c2cd3b766: Provide a base64 encoder compatible with URLs

Summary

URLs don't like some characters used in base64 like '+' or '/',
and padding isn't useful in this context.

Ref T1609.

Test Plan

Unit tests provided

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/Strings/Multibyte/StringUtilities.php:14	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded
Warning	tests/Strings/Multibyte/StringUtilitiesTest.php:60	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	tests/Strings/Multibyte/StringUtilitiesTest.php:68	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	tests/Strings/Multibyte/StringUtilitiesTest.php:110	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	tests/Strings/Multibyte/StringUtilitiesTest.php:114	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

Test Failures

Branch

master

Build Status

Buildable 3535
Build 3784: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/cygdrive/c/dev/nasqueron/keruald/omnitools/tests/Strings/Multibyte/StringUtilitiesTest.php

Event Timeline

dereckson requested review of this revision.Mar 11 2020, 00:18

dereckson created this revision.

Harbormaster completed remote builds in B3535: Diff 5733.Mar 11 2020, 00:18

dereckson accepted this revision.Mar 11 2020, 00:47

This revision is now accepted and ready to land.Mar 11 2020, 00:47

This revision was landed with ongoing or failed builds.Mar 11 2020, 00:48

Closed by commit rKOTfd8c2cd3b766: Provide a base64 encoder compatible with URLs (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTfd8c2cd3b766: Provide a base64 encoder compatible with URLs.

Revision Contents
Changeset List

Path

Size

src/

Strings/

Multibyte/

StringUtilities.php

28 lines

tests/

Strings/

Multibyte/

StringUtilitiesTest.php

30 lines

Diff 5733

src/Strings/Multibyte/StringUtilities.php

Loading...

tests/Strings/Multibyte/StringUtilitiesTest.php

Loading...