Allow to create an arbitrary length ASCII identifier
ClosedPublic
Actions

Authored by dereckson on Mar 11 2020, 00:50.

Tags

None

Referenced Files

	F56086164: D2277.id5736.diff
	Mon, Nov 2, 17:44

	F56086155: D2277.id5735.diff
	Mon, Nov 2, 17:44

	F56086147: D2277.id.diff
	Mon, Nov 2, 17:44

	F55956188: D2277.id.diff
	Sun, Nov 1, 18:25

	F55920957: D2277.id.diff
	Sun, Nov 1, 12:57

	Unknown Object (File)
	Sat, Oct 31, 23:37

	Unknown Object (File)
	Wed, Oct 28, 01:55

	Unknown Object (File)
	Fri, Oct 23, 12:55

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1609: Generate n characters string from m bits

Commits

rKOTf3d54d97b9c8: Allow to create an arbitrary length ASCII identifier

Summary

Reference: https://neilmadden.blog/2018/08/30/moving-away-from-uuids/

Fixes T1609.

Test Plan

Unit tests added.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Tests Skipped

Branch

master

Build Status

Buildable 3536
Build 3785: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 11 2020, 00:50

dereckson created this revision.

Harbormaster completed remote builds in B3536: Diff 5735.Mar 11 2020, 00:50

dereckson accepted this revision.Mar 11 2020, 00:50

This revision is now accepted and ready to land.Mar 11 2020, 00:50

Closed by commit rKOTf3d54d97b9c8: Allow to create an arbitrary length ASCII identifier (authored by dereckson). · Explain WhyMar 11 2020, 00:52

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTf3d54d97b9c8: Allow to create an arbitrary length ASCII identifier.

Revision Contents
Changeset List

Path

Size

src/

Identifiers/

Random.php

9 lines

tests/

Identifiers/

RandomTest.php

7 lines

Diff 5735

View Options

src/Identifiers/Random.php