Paths

Table of Contentst

Lazy evaluate default values
ClosedPublic
Actions

Authored by dereckson on May 30 2020, 22:52.

Tags

None

Referenced Files

	F14821656: D2289.id5769.diff
	Sun, Nov 30, 18:49

	F14708709: D2289.id5767.diff
	Sun, Nov 30, 04:18

	Unknown Object (File)
	Fri, Nov 28, 18:10

	Unknown Object (File)
	Fri, Nov 28, 17:59

	Unknown Object (File)
	Fri, Nov 28, 09:12

	Unknown Object (File)
	Fri, Nov 28, 09:12

	Unknown Object (File)
	Thu, Nov 27, 23:56

	Unknown Object (File)
	Wed, Nov 26, 21:13

View All Files

Subscribers

None

Details

Reviewers

amj
dereckson

Commits

rLF56b5eae8479a: Lazy evaluate default values

Summary

The unwrap_or_else method allows to pass a closure,
and so allows lazy evaluation of the argument.

Test Plan

println!("Mounting at {}", entry_point);

Diff Detail

Repository

rLF Limiting Factor

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-unwrap-or

Build Status

Buildable 3558
Build 3807: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.May 30 2020, 22:52

dereckson created this revision.

Harbormaster completed remote builds in B3556: Diff 5767.May 30 2020, 22:52

I'm not sure the performance improvement justify a commit. These kind of optimization can probably be done by the compiler because String::from("/") have no side effect.

for DefaultConfig too

Harbormaster completed remote builds in B3558: Diff 5769.May 30 2020, 23:58

dereckson accepted this revision.Sep 24 2020, 20:05

This revision is now accepted and ready to land.Sep 24 2020, 20:05

Closed by commit rLF56b5eae8479a: Lazy evaluate default values (authored by dereckson). · Explain WhySep 24 2020, 20:06

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rLF56b5eae8479a: Lazy evaluate default values.

Revision Contents
Changeset List

Path

Size

src/

config.rs

6 lines

Diff 5769

View Options

Lazy evaluate default valuesClosedPublicActions