Paths

Table of Contentst

Differential D253

Revert "Set correct default app.key configuration setting"
ClosedPublic
Actions

Authored by dereckson on Jan 22 2016, 04:09.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 29, 21:01

	Unknown Object (File)
	Wed, Oct 29, 17:12

	Unknown Object (File)
	Wed, Oct 29, 04:27

	Unknown Object (File)
	Wed, Oct 29, 03:13

	Unknown Object (File)
	Wed, Oct 29, 01:43

	Unknown Object (File)
	Sat, Oct 18, 01:11

	Unknown Object (File)
	Fri, Oct 17, 23:38

	Unknown Object (File)
	Tue, Oct 14, 23:26

Subscribers

Details

Reviewers

Maniphest Tasks

T691: Revert APP_KEY to a dummy non 32 character value

Commits

Unknown Object (Diffusion Commit)
rNOTIF292935a0c8d4: Revert "Set correct default app.key configuration setting"

Summary

This reverts commit 53de6354a0b38b229c091ff1fdf44f48eff7de7e.

T690 shows a case where it would be very welcome the application
loudly fails with an encryption key issue exception.

Test Plan

Ensure CI tools (Jenkins jobs, insight.sensiolabs.com)
can create a .env file.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

No Test Coverage

Branch

master

Unit TestsFailed
View All

	Time	Test
	4,358 ms	Jenkins > Nasqueron\Notifications\Tests\Http\Controllers\GitHubGateControllerTest::Unknown Unit Message ("")
	3,935 ms	Jenkins > Nasqueron\Notifications\Tests\Http\Controllers\GitHubGateControllerTest::Unknown Unit Message ("")
	3,806 ms	Jenkins > Nasqueron\Notifications\Tests\PayloadFullTest::Unknown Unit Message ("")
	3,699 ms	Jenkins > Nasqueron\Notifications\Tests\PayloadFullTest::Unknown Unit Message ("")
	3,736 ms	Jenkins > Nasqueron\Notifications\Tests\PayloadFullTest::Unknown Unit Message ("")
		View Full Test Results (10 Failed · 27 Passed)

Event Timeline

dereckson updated this revision to Diff 593.Jan 22 2016, 04:09

dereckson retitled this revision from to Revert "Set correct default app.key configuration setting".

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson added a subscriber: Sandlayth.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/46/ (console: https://ci.nasqueron.org/job/test-notifications-phab/46/console)

dereckson accepted this revision.Jan 22 2016, 04:10

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 04:10

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/46/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/46/console

Perfect, every test making requests failed with RuntimeException: No supported encrypter found. The cipher and / or key length are invalid..

Closed by commit rNOTIF292935a0c8d4: Revert "Set correct default app.key configuration setting" (authored by dereckson, committed by dereckson). · Explain WhyJan 22 2016, 04:16

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in D255: Allow phpunit tests to run without .env file.Jan 22 2016, 04:48

dereckson added a task: T691: Revert APP_KEY to a dummy non 32 character value.Jan 22 2016, 05:01

dereckson mentioned this in rNOTIFbc6b78c70675: Allow phpunit tests to run without .env file.Jan 22 2016, 05:03

dereckson mentioned this in Q4: A PHP application source code has been updated, but all behaves like before. (Answer 4).Jan 24 2016, 07:45

Revision Contents
Changeset List

Path

Size

config/

2 lines

Diff 593

config/app.php

Loading...