Paths

Table of Contentst

Avoid to compare shell_exec() result as false or null
ClosedPublic
Actions

Authored by dereckson on Jan 26 2022, 19:41.

Tags

None

Referenced Files

	F44536390: D2486.id.diff
	Mon, Aug 17, 13:00

	F44528876: D2486.id6267.diff
	Mon, Aug 17, 12:18

	F44528001: D2486.id6266.diff
	Mon, Aug 17, 12:11

	Unknown Object (File)
	Sun, Aug 16, 18:22

	Unknown Object (File)
	Mon, Aug 10, 13:52

	Unknown Object (File)
	Fri, Aug 7, 18:41

	Unknown Object (File)
	Thu, Aug 6, 15:33

	Unknown Object (File)
	Thu, Aug 6, 07:44

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOTaba618f720af: Avoid to compare shell_exec() result as false or null

Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Skipped

Unit

Tests Skipped

Branch

shell_exec_can_return_false_or_null

Build Status

Buildable 3875
Build 4126: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jan 26 2022, 19:41

dereckson created this revision.

Harbormaster completed remote builds in B3875: Diff 6266.Jan 26 2022, 19:41

dereckson accepted this revision.Jan 26 2022, 19:42

This revision is now accepted and ready to land.Jan 26 2022, 19:42

Closed by commit rKOTaba618f720af: Avoid to compare shell_exec() result as false or null (authored by dereckson). · Explain WhyJan 26 2022, 19:43

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTaba618f720af: Avoid to compare shell_exec() result as false or null.

Revision Contents
Changeset List

Path

Size

src/

OS/

CurrentProcess.php

2 lines

Diff 6266

View Options

Avoid to compare shell_exec() result as false or nullClosedPublicActions