Page MenuHomeDevCentral

Avoid to compare shell_exec() result as false or null
ClosedPublic

Authored by dereckson on Jan 26 2022, 19:41.
Tags
None
Referenced Files
F56739565: D2486.id6266.diff
Sun, Nov 8, 20:24
F56399038: D2486.id6267.diff
Thu, Nov 5, 19:18
F56382113: D2486.id6266.diff
Thu, Nov 5, 15:37
F56359057: D2486.id.diff
Thu, Nov 5, 09:58
F56358233: D2486.id6267.diff
Thu, Nov 5, 09:43
F56213043: D2486.diff
Tue, Nov 3, 21:31
F56081111: D2486.id6266.diff
Mon, Nov 2, 16:28
F56081107: D2486.id6267.diff
Mon, Nov 2, 16:28
Subscribers
None

Details

Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Skipped
Unit
Tests Skipped
Branch
shell_exec_can_return_false_or_null
Build Status
Buildable 3875
Build 4126: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Jan 26 2022, 19:42