Page MenuHomeDevCentral

Avoid to compare shell_exec() result as false or null
ClosedPublic

Authored by dereckson on Jan 26 2022, 19:41.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 24, 10:31
Unknown Object (File)
Tue, May 19, 12:45
Unknown Object (File)
Tue, May 19, 12:14
Unknown Object (File)
Tue, May 19, 12:09
Unknown Object (File)
Mon, May 18, 18:41
Unknown Object (File)
Mon, May 18, 07:54
Unknown Object (File)
Sun, May 17, 00:50
Unknown Object (File)
Thu, May 14, 13:44
Subscribers
None

Details

Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Skipped
Unit
Tests Skipped
Branch
shell_exec_can_return_false_or_null
Build Status
Buildable 3875
Build 4126: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Jan 26 2022, 19:42