Page MenuHomeDevCentral

Avoid to compare shell_exec() result as false or null
ClosedPublic

Authored by dereckson on Jan 26 2022, 19:41.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 22, 23:20
Unknown Object (File)
Fri, Feb 20, 18:18
Unknown Object (File)
Tue, Feb 17, 16:16
Unknown Object (File)
Mon, Feb 16, 02:10
Unknown Object (File)
Fri, Feb 13, 21:07
Unknown Object (File)
Thu, Feb 12, 21:28
Unknown Object (File)
Wed, Feb 11, 23:32
Unknown Object (File)
Wed, Feb 11, 18:35
Subscribers
None

Details

Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Skipped
Unit
Tests Skipped
Branch
shell_exec_can_return_false_or_null
Build Status
Buildable 3875
Build 4126: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Jan 26 2022, 19:42