Page MenuHomeDevCentral

Avoid to compare shell_exec() result as false or null
ClosedPublic

Authored by dereckson on Jan 26 2022, 19:41.
Tags
None
Referenced Files
F12522991: D2486.id.diff
Sun, Nov 9, 13:55
Unknown Object (File)
Fri, Nov 7, 16:28
Unknown Object (File)
Fri, Nov 7, 03:42
Unknown Object (File)
Thu, Nov 6, 15:06
Unknown Object (File)
Wed, Nov 5, 16:41
Unknown Object (File)
Wed, Nov 5, 10:16
Unknown Object (File)
Mon, Nov 3, 10:00
Unknown Object (File)
Mon, Nov 3, 09:57
Subscribers
None

Details

Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Skipped
Unit
Tests Skipped
Branch
shell_exec_can_return_false_or_null
Build Status
Buildable 3875
Build 4126: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Jan 26 2022, 19:42