Paths

Table of Contentst

Avoid to compare shell_exec() result as false or null
ClosedPublic
Actions

Authored by dereckson on Jan 26 2022, 19:41.

Tags

None

Referenced Files

	F11725500: D2486.diff
	Tue, Sep 16, 20:40

	Unknown Object (File)
	Mon, Sep 15, 12:07

	Unknown Object (File)
	Sun, Sep 14, 04:37

	Unknown Object (File)
	Sat, Sep 13, 17:34

	Unknown Object (File)
	Fri, Sep 12, 07:14

	Unknown Object (File)
	Thu, Sep 11, 07:38

	Unknown Object (File)
	Sun, Sep 7, 23:01

	Unknown Object (File)
	Sun, Sep 7, 11:22

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOTaba618f720af: Avoid to compare shell_exec() result as false or null

Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Jan 26 2022, 19:41

dereckson created this revision.

Harbormaster completed remote builds in B3875: Diff 6266.Jan 26 2022, 19:41

dereckson accepted this revision.Jan 26 2022, 19:42

This revision is now accepted and ready to land.Jan 26 2022, 19:42

Closed by commit rKOTaba618f720af: Avoid to compare shell_exec() result as false or null (authored by dereckson). · Explain WhyJan 26 2022, 19:43

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTaba618f720af: Avoid to compare shell_exec() result as false or null.

Revision Contents
Changeset List

Path

Size

src/

OS/

CurrentProcess.php

2 lines

Diff 6267

View Options

Avoid to compare shell_exec() result as false or nullClosedPublicActions