Details

Reviewers

dereckson

Commits

rKREPORT463ed23cb7f9: Output report in XML

Summary

This change adds test and XML support.

Test Plan

Unit tests for a regular report are provided.

Only missing some cases if the rapport, or a part of it like properties, is empty.

Diff Detail

Repository

rKREPORT Keruald Report

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/Output/MarkdownOutput.php:44	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

Tests Passed

Branch

adding_xml

Build Status

Buildable 3945
Build 4196: arc lint + arc unit

DorianWinty requested review of this revision.Feb 13 2022, 22:17

DorianWinty created this revision.

rebase against main

DorianWinty retitled this revision from Output report in HTML and Markdown to Output report in XML.Feb 13 2022, 23:12

DorianWinty edited the summary of this revision. (Show Details)

modify the report.xml template to a better one

tests/data/report.xml
6	To be coherent with the section attribute what about this? <entry title="Air Max 90"> One of the more icon color is the infrared. </entry>

src/Output/XMLOutput.php
10	One of the issue with creating XML by hand we don't handle special cases. Imagine a entry with this text: In a report, section are closed by `</section>`. This tag allows to mark the end of the entries. With your code, that would be written as is. With a library to write XML, some strategies would allow the content to be safe: the library could use CDATA - https://en.wikipedia.org/wiki/CDATA the characters could be escaped PHP offers directly such capabilities, for example https://www.php.net/manual/en/example.xmlwriter-simple.php