This change adds test and XML support.
Details
Details
- Reviewers
dereckson - Commits
- rKREPORT463ed23cb7f9: Output report in XML
Unit tests for a regular report are provided.
Only missing some cases if the rapport, or a part of it like properties, is empty.
Diff Detail
Diff Detail
- Repository
- rKREPORT Keruald Report
- Lint
Lint Passed - Unit
Tests Passed - Branch
- adding_xml
- Build Status
Buildable 3949 Build 4200: arc lint + arc unit
Event Timeline
| tests/data/report.xml | ||
|---|---|---|
| 5 | To be coherent with the section attribute what about this? <entry title="Air Max 90">
One of the more icon color is the infrared.
</entry> | |
| src/Output/XMLOutput.php | ||
|---|---|---|
| 9 | One of the issue with creating XML by hand we don't handle special cases. Imagine a entry with this text:
With your code, that would be written as is. With a library to write XML, some strategies would allow the content to be safe:
PHP offers directly such capabilities, for example https://www.php.net/manual/en/example.xmlwriter-simple.php | |