Page MenuHomeDevCentral
Differential D2568

Compute CIDR prefix from netmask for RHEL network scripts
ClosedPublic
Actions

Authored by dereckson on Mar 5 2022, 10:56.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 10:01
Unknown Object (File)
Thu, Nov 14, 07:50
Unknown Object (File)
Wed, Nov 13, 01:08
Unknown Object (File)
Tue, Nov 12, 19:14
Unknown Object (File)
Tue, Nov 12, 16:47
Unknown Object (File)
Mon, Nov 11, 12:28
Unknown Object (File)
Sun, Nov 10, 04:56
Unknown Object (File)
Wed, Nov 6, 12:40
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS0f572c4f7518: Compute CIDR prefix from netmask for RHEL network scripts
Summary

The network scripts use a CIDR notation like PREFIX=24
instead of a netmask notation.

Salt offers a cidr_to_ipv4_netmask but not the other way
around, so a new network execution module is offered.

This is a follow-up for f9dbdab3b579.

Test Plan

Unit tests are provided for network module

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Errors
SeverityLocationCodeMessage
Error_tests/modules/test_network.py:11E731flake8 E731
Error_tests/modules/test_rust.py:9E302flake8 E302
Unit
No Test Coverage
Branch
main
Build Status
Buildable 4022
Build 4274: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 5 2022, 10:56
dereckson created this revision.
Harbormaster completed remote builds in B4022: Diff 6486.Mar 5 2022, 10:56
dereckson updated this revision to Diff 6487.Mar 5 2022, 11:00

Remove fix to Rust tests from this change

Harbormaster completed remote builds in B4023: Diff 6487.Mar 5 2022, 11:00
dereckson updated this revision to Diff 6488.Mar 5 2022, 11:42

Allow to detect netmask in the configuration is invalid

Harbormaster completed remote builds in B4024: Diff 6488.Mar 5 2022, 11:42
dereckson added a comment.Mar 7 2022, 19:12

network is already the name of an execution module:
https://docs.saltproject.io/en/latest/ref/modules/all/salt.modules.network.html

Probably cool to rename it, even if Salt is happy to let us replace modules like that.

dereckson updated this revision to Diff 6500.Mar 7 2022, 19:14

Allow lambda expression

Harbormaster completed remote builds in B4031: Diff 6500.Mar 7 2022, 19:14
dereckson updated this revision to Diff 6501.Mar 7 2022, 19:27

Avoid to shadow network execution module

Harbormaster completed remote builds in B4032: Diff 6501.Mar 7 2022, 19:27
dereckson updated this revision to Diff 6502.Mar 7 2022, 19:30

Rename too in state

Harbormaster completed remote builds in B4033: Diff 6502.Mar 7 2022, 19:30
dereckson accepted this revision.Mar 7 2022, 19:31
This revision is now accepted and ready to land.Mar 7 2022, 19:31
Closed by commit rOPS0f572c4f7518: Compute CIDR prefix from netmask for RHEL network scripts (authored by dereckson). · Explain WhyMar 7 2022, 19:31
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOPS0f572c4f7518: Compute CIDR prefix from netmask for RHEL network scripts.

Revision Contents
Changeset List

PathSize
_modules/
23 lines
_tests/
modules/
29 lines
13 lines
1 line
roles/
core/
network/
files/
RedHat/
2 lines
1 line

Diff 6486

View Options

_modules/network.py

Loading...
View Options

_tests/modules/test_network.py

Loading...
View Options

_tests/modules/test_rust.py

Loading...
View Options

requirements.txt

Loading...
View Options

roles/core/network/files/RedHat/ifcfg-private

Loading...
View Options

roles/core/network/private.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator