Page MenuHomeDevCentral
Differential D281

assertEquals → assertSame in unit tests
ClosedPublic
Actions

Authored by dereckson on Feb 11 2016, 02:04.
Tags
None
Referenced Files
F33813975: D281.id661.diff
Sun, Jun 21, 16:26
F33782308: D281.id658.diff
Sun, Jun 21, 08:09
F33769877: D281.id659.diff
Sun, Jun 21, 04:31
Unknown Object (File)
Fri, Jun 19, 15:26
Unknown Object (File)
Fri, Jun 19, 13:47
Unknown Object (File)
Thu, Jun 18, 20:51
Unknown Object (File)
Thu, Jun 18, 15:29
Unknown Object (File)
Thu, Jun 18, 15:29
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIFead5f15a8796: assertEquals → assertSame in unit tests
Summary

The tests now use assertSame to assert type is respected too.

We keep assertEquals in EventServiceProviderTest::testOmittedFiles,
as we there compare two arrays, regardless of the order of the items.

Test Plan

phpunit

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
test-assertSame

Event Timeline

dereckson updated this revision to Diff 658.Feb 11 2016, 02:04
dereckson retitled this revision from to assertEquals → assertSame in unit tests.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Feb 11 2016, 02:04

Build started: https://ci.nasqueron.org/job/test-notifications-phab/77/ (console: https://ci.nasqueron.org/job/test-notifications-phab/77/console)

dereckson planned changes to this revision.Feb 11 2016, 02:04
dereckson added inline comments.
tests/Actions/ActionsReportTest.php
61

This is an assertEquals too.

dereckson updated this revision to Diff 659.Feb 11 2016, 02:08
dereckson edited edge metadata.

assertEquals in suggestion to fix a testReport issue

alken-orin added a comment.Feb 11 2016, 02:10

Build is green https://ci.nasqueron.org/job/test-notifications-phab/77/ for more details.

alken-orin added a comment.Feb 11 2016, 02:10

Build started: https://ci.nasqueron.org/job/test-notifications-phab/78/ (console: https://ci.nasqueron.org/job/test-notifications-phab/78/console)

alken-orin added a comment.Feb 11 2016, 02:16

Build is green https://ci.nasqueron.org/job/test-notifications-phab/78/ for more details.

dereckson accepted this revision.Feb 11 2016, 04:36
dereckson edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2016, 04:36
Closed by commit rNOTIFead5f15a8796: assertEquals → assertSame in unit tests (authored by dereckson, committed by dereckson). · Explain WhyFeb 11 2016, 04:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
tests/
Actions/
2 lines
12 lines
2 lines
Analyzers/
GitHub/
Events/
26 lines
4 lines
Notifications/
14 lines
Providers/
4 lines
Services/
12 lines

Diff 658

View Options

tests/Actions/AMQPActionTest.php

Loading...
View Options

tests/Actions/ActionsReportTest.php

Loading...
View Options

tests/Actions/NotifyNewCommitsActionTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/PushEventTest.php

Loading...
View Options

tests/Analyzers/GitHub/GitHubPayloadAnalyzerConfigurationTest.php

Loading...
View Options

tests/Notifications/DockerHubNotificationTest.php

Loading...
View Options

tests/Providers/ServicesServiceProviderTest.php

Loading...
View Options

tests/Services/ServicesTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator