Details

Reviewers

dereckson

Maniphest Tasks

T1750: Import FANTOIR database

Commits

rDSfbabea18bd71: Fetch last FANTOIR file

Summary

Query the data.economie.gouv.fr API to get metadata about last FANTOIR file.

Download it if not already existing in the working directory.

Print FANTOIR_FILE=<download and extracted file> on success.

The code download itself the file, but call unzip to handle unzip operation.

Test Plan

Downloaded file when and when not existing.

Diff Detail

Repository

rDS Nasqueron Datasources

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

fetch

Build Status

Buildable 4341
Build 4608: arc lint + arc unit

dereckson requested review of this revision.Jan 15 2023, 05:57

dereckson created this revision.

Blocked by publication of opendatasoft-explore-api library.

Plan is to switch to a manyrepo, ie a monorepo with script to export to fantoir-datasource, opendatasoft-explore-api, and the future ones.

src/commands/fetch/mod.rs
28 ↗	(On Diff #6951)	Conflict with unzip exit code Change and update doc at https://agora.nasqueron.org/Fantoir-datasource

Switch to monorepo, rebase against monorepo state and against D2745

We're blocked by D2745, but this code works fine and download, extract correctly the file.

We instantiate unzip because the ZIP libraries are a real pain, and we can't bring a lot of added value to the tool.

We also need to document unzip is needed in the README for fetch command.

fantoir-datasource/Cargo.toml
14	How do we plan to actually manage this? It makes sense for development, but not great for packaging: cargo install fantoir-datasource should be able to fetch and compile opendatasoft-explore-api
fantoir-datasource/src/commands/fetch/fantoir_file.rs
107	Let's add the protocol, so nobody will be confused "where is this file for the test".