Page MenuHomeDevCentral

Refactoring: Service::getInstanceName()
ClosedPublic

Authored by dereckson on Feb 23 2016, 19:22.
Tags
None
Referenced Files
F11669857: D302.id709.diff
Mon, Sep 8, 15:01
Unknown Object (File)
Tue, Aug 26, 20:24
Unknown Object (File)
Tue, Aug 26, 04:49
Unknown Object (File)
Tue, Aug 26, 04:49
Unknown Object (File)
Fri, Aug 22, 11:36
Unknown Object (File)
Thu, Aug 21, 15:19
Unknown Object (File)
Wed, Aug 20, 07:49
Unknown Object (File)
Tue, Aug 19, 21:14
Subscribers

Details

Summary

The config:show command would like a string to represent the instance
in an array. We transfer the responsability to provide this string to
the Service class.

Test Plan
  • A new test is provided to test the method in the two cases
  • php artisan config:show

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
service-getInstanceName

Event Timeline

dereckson retitled this revision from to Refactoring: Service::getInstanceName().
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2016, 20:25
This revision was automatically updated to reflect the committed changes.