Page MenuHomeDevCentral

Configure Flake8 linter for Arcanist
ClosedPublic

Authored by dereckson on Feb 14 2023, 19:19.
Tags
None
Referenced Files
F24663306: D2795.id7093.diff
Tue, Mar 3, 23:19
F24663288: D2795.id7094.diff
Tue, Mar 3, 23:18
F24663066: D2795.diff
Tue, Mar 3, 22:58
F24661822: D2795.diff
Tue, Mar 3, 21:14
Unknown Object (File)
Fri, Feb 27, 13:39
Unknown Object (File)
Fri, Feb 27, 13:34
Unknown Object (File)
Mon, Feb 23, 14:28
Unknown Object (File)
Mon, Feb 23, 14:22
Subscribers
None

Details

Summary

Allow to specify pillar and other Salt dictionaries as builtins,
so flake8 won't complain anymore those names don't exist.

Lint also the .sls #!py files, as they are written in Python too.

This currently needs to use Nasqueron version of arcanist, production branch:
https://github.com/nasqueron/arcanist/commit/15aa482eacd90fdbd238bc8b7a17c4bbba8a0bdd

Test Plan

arc lint

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
main
Build Status
Buildable 4427
Build 4694: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Feb 14 2023, 19:20
This revision was automatically updated to reflect the committed changes.