Page MenuHomeDevCentral
Differential D302

Refactoring: Service::getInstanceName()
ClosedPublic
Actions

Authored by dereckson on Feb 23 2016, 19:22.
Tags
None
Referenced Files
F9678328: D302.id712.diff
Wed, Jun 11, 18:50
F9641020: D302.id709.diff
Tue, Jun 10, 22:56
Unknown Object (File)
Tue, Jun 10, 19:43
Unknown Object (File)
Tue, Jun 10, 07:00
Unknown Object (File)
Mon, Jun 9, 23:13
Unknown Object (File)
Mon, Jun 9, 17:17
Unknown Object (File)
Mon, Jun 9, 11:47
Unknown Object (File)
Tue, Jun 3, 22:58
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIFa8685fea32e2: Refactoring: Service::getInstanceName()
Summary

The config:show command would like a string to represent the instance
in an array. We transfer the responsability to provide this string to
the Service class.

Test Plan
  • A new test is provided to test the method in the two cases
  • php artisan config:show

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 709.Feb 23 2016, 19:22
dereckson retitled this revision from to Refactoring: Service::getInstanceName().
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Feb 23 2016, 19:35

Build started: https://ci.nasqueron.org/job/test-notifications-phab/86/ (console: https://ci.nasqueron.org/job/test-notifications-phab/86/console)

alken-orin added a comment.Feb 23 2016, 19:42

Build is green https://ci.nasqueron.org/job/test-notifications-phab/86/ for more details.

dereckson accepted this revision.Feb 23 2016, 20:25
dereckson edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2016, 20:25
Closed by commit rNOTIFa8685fea32e2: Refactoring: Service::getInstanceName() (authored by dereckson, committed by dereckson). · Explain WhyFeb 23 2016, 20:26
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Console/
Commands/
7 lines
Services/
13 lines
tests/
Services/
45 lines

Diff 712

View Options

app/Console/Commands/ConfigShow.php

Loading...
View Options

app/Services/Service.php

Loading...
View Options

tests/Services/ServiceTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator