Page MenuHomeDevCentral
Differential D2842

Avoid duplicate proxy_redirect nginx directive
ClosedPublic
Actions

Authored by DorianWinty on Mar 5 2023, 18:37.
Tags
None
Referenced Files
F3113091: D2842.id.diff
Mon, Jun 17, 00:49
F3110232: D2842.id7249.diff
Sun, Jun 16, 14:46
Unknown Object (File)
Sat, Jun 15, 11:50
Unknown Object (File)
Sat, Jun 15, 09:01
Unknown Object (File)
Fri, Jun 14, 09:55
Unknown Object (File)
Wed, Jun 12, 18:08
Unknown Object (File)
Tue, Jun 11, 07:56
Unknown Object (File)
Tue, Jun 11, 04:38
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS76a2ce59699e: Avoid duplicate proxy_redirect nginx directive
Summary

Previously, nginx accepted two values for proxy_redirect.

In more recent version, this is a fatal error.

Move the directive into each location proxy block.

Test Plan

Tested on Dwellers.

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
proxy (branched from main)
Build Status
Buildable 4490
Build 4757: arc lint + arc unit

Event Timeline

DorianWinty requested review of this revision.Mar 5 2023, 18:37
DorianWinty created this revision.
DorianWinty edited the test plan for this revision. (Show Details)Mar 5 2023, 18:53
dereckson accepted this revision.Mar 5 2023, 18:54
dereckson retitled this revision from Avoid duplicate proxy_redirect off to Avoid duplicate proxy_redirect nginx directive.
dereckson edited the summary of this revision. (Show Details)
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mar 5 2023, 18:56
Harbormaster completed remote builds in B4490: Diff 7245.Mar 5 2023, 20:36
Closed by commit rOPS76a2ce59699e: Avoid duplicate proxy_redirect nginx directive (authored by DorianWinty). · Explain WhyMar 5 2023, 20:36
This revision was automatically updated to reflect the committed changes.
DorianWinty added a commit: rOPS76a2ce59699e: Avoid duplicate proxy_redirect nginx directive.

Revision Contents
Changeset List

PathSize
roles/
paas-docker/
nginx/
files/
includes/
2 lines
vhosts/
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
3 lines
1 line
1 line
1 line
1 line

Diff 7245

View Options

roles/paas-docker/nginx/files/includes/proxy_params

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/_default.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/acme_dns.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/auth-grove.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/bugzilla.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/cachet.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/etherpad.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/hauk.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/jenkins.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/openfire.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/phabricator.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/pixelfed.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/rabbitmq.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/sentry.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/tommy.conf

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator