Page MenuHomeDevCentral
Differential D311

Report exceptions to Sentry
ClosedPublic
Actions

Authored by dereckson on Mar 2 2016, 01:34.
Tags
None
Referenced Files
F3930503: D311.id.diff
Sun, Dec 22, 14:12
Unknown Object (File)
Sun, Dec 8, 16:47
Unknown Object (File)
Sat, Dec 7, 12:37
Unknown Object (File)
Fri, Dec 6, 05:21
Unknown Object (File)
Fri, Dec 6, 01:04
Unknown Object (File)
Thu, Dec 5, 13:03
Unknown Object (File)
Thu, Dec 5, 05:19
Unknown Object (File)
Tue, Dec 3, 09:33
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T764: Integrate with Sentry
Commits
rNOTIFec2a45bc3d81: Report exceptions to Sentry
Summary

We provide a new service provider, SentryServiceProvider,
bound to the 'raven' application container key, to provide
a Raven client.

The clien will connect to Sentry through a DSN configured in
SENTRY_DSN environment variable.

The exception handler sends exceptions to Sentry,
but not for unit tests.

Fixes T764.

Test Plan

Tested with the sentry.nasqueron.org installation (see T684).

The test procedure involved to check Sentry received something
in the following scenarii:

  • fire exception through a new HTTP route
  • explicitely call Raven facade through php artisan tinker
  • allow unit tests to report exceptions

Unit tests added for the service provider and the facade.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
sentry

Event Timeline

dereckson updated this revision to Diff 731.Mar 2 2016, 01:34
dereckson retitled this revision from to Report exceptions to Sentry.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson added a task: T764: Integrate with Sentry.
alken-orin added a subscriber: alken-orin.Mar 2 2016, 01:55

Build started: https://ci.nasqueron.org/job/test-notifications-phab/90/ (console: https://ci.nasqueron.org/job/test-notifications-phab/90/console)

alken-orin added a comment.Mar 2 2016, 02:16

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/90/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/90/console

alken-orin added a comment.Mar 2 2016, 02:18

Build started: https://ci.nasqueron.org/job/test-notifications-phab/91/ (console: https://ci.nasqueron.org/job/test-notifications-phab/91/console)

alken-orin added a comment.Mar 2 2016, 02:26

Build is green https://ci.nasqueron.org/job/test-notifications-phab/91/ for more details.

dereckson updated this revision to Diff 732.Mar 2 2016, 03:01
dereckson edited edge metadata.

More tests

alken-orin added a comment.Mar 2 2016, 03:02

Build started: https://ci.nasqueron.org/job/test-notifications-phab/92/ (console: https://ci.nasqueron.org/job/test-notifications-phab/92/console)

alken-orin added a comment.Mar 2 2016, 03:11

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/92/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/92/console

dereckson updated this revision to Diff 733.EditedMar 2 2016, 03:14
dereckson edited edge metadata.

Allow test to succeed when SENTRY_DSN isn't set

alken-orin added a comment.Mar 2 2016, 03:15

Build started: https://ci.nasqueron.org/job/test-notifications-phab/93/ (console: https://ci.nasqueron.org/job/test-notifications-phab/93/console)

alken-orin added a comment.Mar 2 2016, 03:25

Build is green https://ci.nasqueron.org/job/test-notifications-phab/93/ for more details.

dereckson planned changes to this revision.Mar 2 2016, 03:40
dereckson added inline comments.
tests/Exceptions/HandlerTest.php
40 ↗(On Diff #733)

\n

dereckson updated this revision to Diff 734.Mar 2 2016, 03:44

\n

dereckson accepted this revision.Mar 2 2016, 03:44
dereckson edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2016, 03:44
alken-orin added a comment.Mar 2 2016, 03:44

Build started: https://ci.nasqueron.org/job/test-notifications-phab/94/ (console: https://ci.nasqueron.org/job/test-notifications-phab/94/console)

dereckson marked an inline comment as done.Mar 2 2016, 03:45
Closed by commit rNOTIFec2a45bc3d81: Report exceptions to Sentry (authored by dereckson, committed by dereckson). · Explain WhyMar 2 2016, 03:46
This revision was automatically updated to reflect the committed changes.
alken-orin added a comment.Mar 2 2016, 03:59

Build is green https://ci.nasqueron.org/job/test-notifications-phab/94/ for more details.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Exceptions/
25 lines--
Facades/
29 lines50%
Loading...
Providers/
30 lines100%
Loading...
3 lines--
config/
2 lines--
4 lines--
tests/
Facades/
22 lines--
Providers/
14 lines--

Diff 731

View Options

app/Exceptions/Handler.php

Loading...
View Options

app/Facades/Raven.php

Loading...
View Options

app/Providers/SentryServiceProvider.php

Loading...
View Options

composer.json

Loading...
View Options

config/app.php

Loading...
View Options

config/services.php

Loading...
View Options

tests/Facades/RavenTest.php

Loading...
View Options

tests/Providers/SentryServiceProviderTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator