Differential D2920

Integrate Sentry and GitHub
ClosedPublic
Actions

Authored by dereckson on Mar 25 2023, 16:22.

Details

Reviewers

dereckson

Maniphest Tasks

T1806: Integrate Sentry and GitHub

Commits

rOPS640de07abfce: Integrate Sentry and GitHub

Summary

A custom GitHub application has been created in the Nasqueron account,
and credentials published to Vault under apps/sentry/github key.

The keys under apps/sentry/github match the expected settings names,
that allows the use of the for loop instead of querying the 6 of them.

Those credentials are in apps/ and not ops/secrets/ as they don't need
to be deployed by Salt, they can directly been fetched by Sentry config.
As such, the updated Vault policy is the one used by Sentry config.

Reference: https://develop.sentry.dev/integrations/github/

Ref T1806

Test Plan

Deploy on docker-002 for sentry_web

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:119	F405	flake8 F405
Error	roles/paas-docker/containers/files/sentry/etc/sentry.conf.py:217	E501	flake8 E501

Unit

No Test Coverage

Branch

sentry-github

Build Status

Buildable 4602
Build 4874: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 25 2023, 16:22

dereckson created this revision.

Harbormaster completed remote builds in B4601: Diff 7438.Mar 25 2023, 16:22

⚠ A little tricky to test this as it will be deployed to live container. ⚠

I'd suggest to first deploy the Vault policy, then spin a new test container
and see if it has correctly the settings: the web container is only a client,
any automated write occurs in other containers, so that should be safe, and
won't disrupt our instance.

Test container:

+    sentry_web_test:
+      app_port: 26081
+      host: sentry.nasqueron.org
+      command: run web
+      realm: nasqueron
+      network: sentry
+

dereckson planned changes to this revision.Mar 25 2023, 16:36

dereckson added inline comments.

roles/vault/policies/files/sentry.hcl
16	!! Configuration error: ConfigurationError('Forbidden: 1 error occurred:\n\t* permission denied\n\n, on get https://172.27.27.7:8200/v1/apps/data/sentry/github')