Page MenuHomeDevCentral

Propagate errors if we can't handle it in vault_get
ClosedPublic

Authored by dereckson on Apr 12 2023, 00:01.
Tags
None
Referenced Files
F12127544: D3003.diff
Sun, Oct 5, 18:20
Unknown Object (File)
Tue, Sep 30, 04:42
Unknown Object (File)
Thu, Sep 25, 22:29
Unknown Object (File)
Wed, Sep 24, 05:17
Unknown Object (File)
Tue, Sep 23, 12:06
Unknown Object (File)
Tue, Sep 23, 04:33
Unknown Object (File)
Mon, Sep 22, 15:40
Unknown Object (File)
Sat, Sep 20, 09:01
Subscribers
None

Details

Summary

When an error is caught in vault_get, it only handles the 403 case.

If vault is currently in 503 (still sealed for example), it does nothing,
so the return fails with can't read "credential": no such variable.

This change allows vault_get to propagate instead the error:
"Vault returned HTTP/1.1 503 Service Unavailable, 200 OK was expected."

Test Plan

Tested on Wearg

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
vault-unsealed
Build Status
Buildable 4749
Build 5030: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Apr 12 2023, 00:09