Page MenuHomeDevCentral

Propagate errors if we can't handle it in vault_get
ClosedPublic

Authored by dereckson on Apr 12 2023, 00:01.
Tags
None
Referenced Files
F9593214: D3003.id7668.diff
Mon, Jun 9, 11:40
F9593056: D3003.id7669.diff
Mon, Jun 9, 11:29
F9586595: D3003.diff
Mon, Jun 9, 02:29
Unknown Object (File)
Tue, May 20, 01:09
Unknown Object (File)
Mon, May 19, 23:48
Unknown Object (File)
Mon, May 12, 16:20
Unknown Object (File)
Mon, May 12, 15:40
Unknown Object (File)
Sun, May 11, 10:28
Subscribers
None

Details

Summary

When an error is caught in vault_get, it only handles the 403 case.

If vault is currently in 503 (still sealed for example), it does nothing,
so the return fails with can't read "credential": no such variable.

This change allows vault_get to propagate instead the error:
"Vault returned HTTP/1.1 503 Service Unavailable, 200 OK was expected."

Test Plan

Tested on Wearg

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
vault-unsealed
Build Status
Buildable 4749
Build 5030: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Apr 12 2023, 00:09