Page MenuHomeDevCentral

Propagate errors if we can't handle it in vault_get
ClosedPublic

Authored by dereckson on Apr 12 2023, 00:01.
Tags
None
Referenced Files
F3767813: D3003.diff
Sat, Nov 23, 03:38
Unknown Object (File)
Sun, Nov 17, 07:07
Unknown Object (File)
Sun, Nov 17, 07:07
Unknown Object (File)
Sun, Nov 17, 07:07
Unknown Object (File)
Sun, Nov 17, 07:07
Unknown Object (File)
Sun, Nov 17, 01:26
Unknown Object (File)
Tue, Nov 12, 12:35
Unknown Object (File)
Tue, Nov 12, 01:06
Subscribers
None

Details

Summary

When an error is caught in vault_get, it only handles the 403 case.

If vault is currently in 503 (still sealed for example), it does nothing,
so the return fails with can't read "credential": no such variable.

This change allows vault_get to propagate instead the error:
"Vault returned HTTP/1.1 503 Service Unavailable, 200 OK was expected."

Test Plan

Tested on Wearg

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
vault-unsealed
Build Status
Buildable 4749
Build 5030: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Apr 12 2023, 00:09