Paths

Table of Contentst

Differential D3005

Reduce the length of GRE interface name
ClosedPublic
Actions

Authored by dereckson on Apr 12 2023, 23:33.

Details

Reviewers

dereckson

Maniphest Tasks

T1832: Fix core role for Debian nodes

Commits

rOPSaa208267aeb6: Reduce the length of GRE interface name

Summary

The define IFNAMSIZ in Linux kernel defines the maximum length of an interface
name. By default, 16 characters, including the final '\0'.

As such, names like gre-drake_via_router-001 are too long.

gre-drake seems to be descriptive enough, as a node has only one GRE tunnel
if it's not our router.

Reference: include/uapi/linux/if.h

Ref T1832

Test Plan

Deploy on cloudhugger, ifconfig gre-drake

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	_modules/node.py:417	E501	flake8 E501

Unit

No Test Coverage

Branch

fix-cloudhugger

Build Status

Buildable 4752
Build 5033: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 12 2023, 23:33

dereckson created this revision.

Harbormaster completed remote builds in B4752: Diff 7673.Apr 12 2023, 23:33

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/if.h

if.h

#if __UAPI_DEF_IF_IFNAMSIZ
#define	IFNAMSIZ	16
#endif /* __UAPI_DEF_IF_IFNAMSIZ */
#define	IFALIASZ	256
#define	ALTIFNAMSIZ	128
#include <linux/hdlc/ioctl.h>

dereckson accepted this revision.Apr 12 2023, 23:34

This revision is now accepted and ready to land.Apr 12 2023, 23:34

This revision was landed with ongoing or failed builds.Apr 12 2023, 23:35

Closed by commit rOPSaa208267aeb6: Reduce the length of GRE interface name (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPSaa208267aeb6: Reduce the length of GRE interface name.

dereckson added a reverting change: D3063: Restore GRE tunnels rc names.Apr 27 2023, 22:41

dereckson added a reverting change: rOPS690b374144d7: Restore GRE tunnels rc names.Apr 27 2023, 22:42

Revision Contents
Changeset List

Path

Size

_modules/

node.py

2 lines

roles/

core/

network/

gre.sls

4 lines

Diff 7673

View Options

_modules/node.py