Paths

Table of Contentst

Avoid to mark a site initialized on failure
ClosedPublic
Actions

Authored by dereckson on Apr 14 2023, 21:11.

Tags

None

Referenced Files

	F55833832: D3015.id7695.diff
	Sat, Oct 31, 22:39

	F55833827: D3015.id7696.diff
	Sat, Oct 31, 22:39

	F55833799: D3015.id.diff
	Sat, Oct 31, 22:39

	F55818338: D3015.id.diff
	Sat, Oct 31, 19:25

	F55702998: D3015.diff
	Sat, Oct 31, 00:21

	F55697607: D3015.id7695.diff
	Fri, Oct 30, 23:35

	Unknown Object (File)
	Fri, Oct 30, 14:13

	Unknown Object (File)
	Fri, Oct 30, 14:13

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rALK3124e5a90b11: Avoid to mark a site initialized on failure

Summary

Check the recipe status to be successful, and if not, don't mark
as initialized.

Init script should be documented to use the following exit codes:

Success: 0
Failure: 2

Test Plan

alkane init

Diff Detail

Repository

rALK Alkane

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

dont-initialize-too-soon

Build Status

Buildable 4765
Build 5046: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 14 2023, 21:11

dereckson created this revision.

Harbormaster completed remote builds in B4765: Diff 7695.Apr 14 2023, 21:11

dereckson accepted this revision.Apr 14 2023, 21:12

This revision is now accepted and ready to land.Apr 14 2023, 21:12

Closed by commit rALK3124e5a90b11: Avoid to mark a site initialized on failure (authored by dereckson). · Explain WhyApr 14 2023, 21:12

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rALK3124e5a90b11: Avoid to mark a site initialized on failure.

Revision Contents
Changeset List

Path

Size

src/

actions.rs

2 lines

runner/

mod.rs

2 lines

Diff 7695

View Options

src/actions.rs