Differential D3205

Add basic navbar with API integration
ClosedPublic
Actions

Authored by inidal on Jun 22 2023, 20:04.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 19:25

	Unknown Object (File)
	Fri, Dec 13, 20:15

	Unknown Object (File)
	Fri, Dec 13, 19:54

	Unknown Object (File)
	Thu, Dec 12, 19:43

	Unknown Object (File)
	Fri, Dec 6, 12:05

	Unknown Object (File)
	Fri, Dec 6, 12:05

	Unknown Object (File)
	Thu, Dec 5, 12:29

	Unknown Object (File)
	Tue, Dec 3, 07:46

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1907: Add in-app config feature
T1860: Add Foundation capabilities to Vue
T1906: Add API integration
T1905: Create Navbar

Commits

rSP3e86938490e9: Add basic navbar with API integration

Summary

This differential revision could serve as a reference to add a component
and an API functionality.

Add in-app config feature for the navbar
Add navbar component
Add API integration
Organize routes
Add HomeView file
Add .env.development with example
Fix indentation
Integrate Foundation Framework
Delete unwanted code

Diff Detail

Repository

Lint

Lint Passed

Unit

No Test Coverage

Branch

navbar-with-api-integration

Build Status

Buildable 5043
Build 5324: arc lint + arc unit

Event Timeline

inidal requested review of this revision.Jun 22 2023, 20:04

inidal created this revision.

Harbormaster completed remote builds in B5043: Diff 8200.Jun 22 2023, 20:04

dereckson added a task: T1905: Create Navbar.Jun 22 2023, 22:12

dereckson added a task: T1906: Add API integration.

inidal added a task: T1860: Add Foundation capabilities to Vue.Jun 23 2023, 01:29

inidal added a task: T1907: Add in-app config feature.Jun 23 2023, 01:31

dereckson requested changes to this revision.Jun 30 2023, 21:18

dereckson added inline comments.

frontend/servpulse-frontend/.env.development
1	If we use an environment here, it's evaluated at build time. That means we need to build the application with injection of environment variables. The API endpoint is a configuration used by the client. As such, it would be interesting to move this setting to a configuration file read by the JavaScript code executed in the browser.
frontend/servpulse-frontend/index.html
8	We don't take this opportunity to change the title?
frontend/servpulse-frontend/src/plugins/api.js
5	That will be solved when moving to a configuration.

This revision now requires changes to proceed.Jun 30 2023, 21:18

inidal added inline comments.Jul 1 2023, 00:16

frontend/servpulse-frontend/index.html
8	I would prefer not to, but let's take care of this change during the SEO process. Additionally, we can make this tag dynamic by pulling data from the app's state.

inidal added inline comments.Jul 1 2023, 00:38

frontend/servpulse-frontend/.env.development
1	https://devcentral.nasqueron.org/D3205#inline-3922
frontend/servpulse-frontend/src/plugins/api.js
5	We should add a state to the app using Redux's store. This way, we can manage the data in a centralized manner and ensure that it is available across different components. We'll also be able to dispatch actions that updates the state and retrieve the updated data in our components. If this sounds good, let me know and I'll create a new ticket for it.

dereckson accepted this revision.Jul 17 2023, 20:19

This revision is now accepted and ready to land.Jul 17 2023, 20:19

Per comments and discussions last weeks, we'll address the configuration store later.

Closed by commit rSP3e86938490e9: Add basic navbar with API integration (authored by inidal). · Explain WhyJul 17 2023, 21:46

This revision was automatically updated to reflect the committed changes.

inidal added a commit: rSP3e86938490e9: Add basic navbar with API integration.

Revision Contents
Changeset List

Path

Size

backend/

servpulse-backend/

2 lines

config/

15 lines

controllers/

configController.js

12 lines

models/

9 lines

routes/

configRoutes.js

7 lines

frontend/

servpulse-frontend/

.env.development

3 lines

23 lines

1 line

src/

82 lines

components/

WelcomeItem.vue

home/

NavbarSection.vue

69 lines

icons/

IconCommunity.vue

IconDocumentation.vue

IconEcosystem.vue

IconSupport.vue

IconTooling.vue

15 lines

plugins/

11 lines

router/

16 lines

views/

4 lines

Diff 8200

backend/servpulse-backend/app.js

Loading...

backend/servpulse-backend/config/app.json

Loading...

backend/servpulse-backend/controllers/configController.js

Loading...

backend/servpulse-backend/models/configModel.js

Loading...

backend/servpulse-backend/routes/configRoutes.js

Loading...

frontend/servpulse-frontend/.env.development

Loading...

frontend/servpulse-frontend/index.html

Loading...

frontend/servpulse-frontend/package.json

Loading...

frontend/servpulse-frontend/src/App.vue

Loading...

frontend/servpulse-frontend/src/components/HelloWorld.vue

Loading...

frontend/servpulse-frontend/src/components/TheWelcome.vue

Loading...

frontend/servpulse-frontend/src/components/WelcomeItem.vue

Loading...

frontend/servpulse-frontend/src/components/home/NavbarSection.vue

Loading...

frontend/servpulse-frontend/src/components/icons/IconCommunity.vue

Loading...

frontend/servpulse-frontend/src/components/icons/IconDocumentation.vue

Loading...

frontend/servpulse-frontend/src/components/icons/IconEcosystem.vue

Loading...

frontend/servpulse-frontend/src/components/icons/IconSupport.vue

Loading...

frontend/servpulse-frontend/src/components/icons/IconTooling.vue

Loading...

frontend/servpulse-frontend/src/main.js

Loading...

frontend/servpulse-frontend/src/plugins/api.js

Loading...

frontend/servpulse-frontend/src/router/index.js

Loading...

frontend/servpulse-frontend/src/views/AboutView.vue

Loading...

frontend/servpulse-frontend/src/views/HomeView.vue

Loading...